Comment on attachment 95408
initialize stuff for gddr5 ram

Review of attachment 95408:
-----------------------------------------------------------------

::: drivers/gpu/drm/nouveau/core/subdev/fb/ramnva3.c
@@ +365,5 @@
> +             /* XXX this algorithm is insane, find some sanity to it. */
> +             /* [1] MMIO32 R 0x100268 0x30030200 PFB.SUBPART_CONFIG => { 
> SELECT_MASK = 0x2 | UNK16 = 0x3 | ENABLE_MASK = 0x3 } */
> +             nv_wr32(pfb, 0x10fcac, 0x00001f01);
> +             for (o = 0; o < 4; o++) {
> +                     int off = offsets[i];

maybe int off = offsets[o]; ?

@@ +387,5 @@
> +                     for (i = 0x20, idx = 0; i < 0x30; i++, idx++) {
> +                             int pat = pattern[2 + (idx % 2)];
> +                             if (i == 0x26)
> +                                     pat = 0;
> +                             if (i == 0x1f)

looks like this condition is always false in this for-loop

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to xserver-xorg-video-nouveau in Ubuntu.
https://bugs.launchpad.net/bugs/1217585

Title:
  System hangs after some time with nouveau and GT240

Status in Accelerated Xorg driver for nVidia cards:
  Confirmed
Status in “xserver-xorg-video-nouveau” package in Ubuntu:
  Confirmed
Status in “xserver-xorg-video-nouveau” package in Fedora:
  Unknown

Bug description:
  With the Nouveau driver I get random system hangs in the Live CD - any
  version since it was switched to nouveau up until today's daily
  images. It happens after half an hour to a couple of hours usage and
  affects installed systems as well, until they are switched to the
  proprietary driver.

  This is a well known bug in other trackers but I can't see it anywhere
  on Launchpad, so I'm reporting it and will add bug watches.

  ProblemType: Bug
  DistroRelease: Ubuntu 13.10
  Package: xserver-xorg-video-nouveau 1:1.0.8-0ubuntu3
  ProcVersionSignature: Ubuntu 3.11.0-4.9-generic 3.11.0-rc7
  Uname: Linux 3.11.0-4-generic x86_64
  ApportVersion: 2.12.1-0ubuntu2
  Architecture: amd64
  CasperVersion: 1.336
  Date: Tue Aug 27 22:16:06 2013
  LiveMediaBuild: Xubuntu 13.10 "Saucy Salamander" - Alpha amd64 (20130827)
  MarkForUpload: True
  ProcEnviron:
   LANGUAGE=en_US
   TERM=xterm
   PATH=(custom, no user)
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: xserver-xorg-video-nouveau
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nouveau/+bug/1217585/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to