(In reply to comment #46)
> Empathy: http://cgit.collabora.com/git/user/xclaesse/empathy.git/log/?h=otr
Ok for the first commit.
Second commit:
+ tuple = empathy_gdbus_channel_interface_otr1_get_remote_fingerprint (
+ priv->otr_proxy);
I have no idea how these new generated API work, but GVariant API are usually
'return: (transfer full)' that's not the case here?
+ level = empathy_gdbus_channel_interface_otr1_get_trust_level (
+ priv->otr_proxy);
I guess this returns a cached value (not a blocking call) right? What happens
if the proxy is not ready yet? Aren't we going to treat it as a wrong level and
update it right after?
+ g_variant_get (tuple, "(&s@ay)", &fp, NULL);
What's the 'ay' arg being ignored? Please add at least one comment.
What happens if the user doesn't trust the fingerprint. The
communication is still crypted?
+ N_("/otr <action>: Interact with the Off-The-Record system.
Possible actions are:\n"
Is there a way to check (without changing) the current trust level?
+ g_variant_get (tuple, "(s@ay)", NULL, &fp_variant);
+ empathy_gdbus_channel_interface_otr1_call_initialize (
+ priv->otr_proxy, NULL, NULL, NULL);
How does the user know if the operation succeeded or not? Just wait for
the level update message? I think we should explicitely say if it failed
so user explicitely know the conversation is not "safe".
+ g_variant_get (tuple, "(s@ay)", NULL, &fp_variant);
I think fp_variant is leaked.
chat_command_otr() will crash/assert if one of the D-Bus API failed.
Also, shouldn't we use async API here?
trust_level_to_str(): I'd mention "encrypt using OTR" to be clearer and
avoid confusion my server encryption.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to empathy in Ubuntu.
https://bugs.launchpad.net/bugs/296867
Title:
empathy needs to support OTR encryption
Status in Chat app, and Telepathy user interface:
Confirmed
Status in One Hundred Papercuts:
Invalid
Status in Telepathy framework - library:
Confirmed
Status in “empathy” package in Ubuntu:
Triaged
Status in “libtelepathy” package in Ubuntu:
Confirmed
Status in “empathy” package in Fedora:
Won't Fix
Bug description:
Binary package hint: empathy
Hello,
I just tried empathy (the Intrepid version) and it looked very solid and
stable. There were a few minor things that could be improved (e.g.
automatically resizing the contact list), but that is not the topic here.
The reason why I won't switch to empathy from pidgin is the missing OTR
support (http://www.cypherpunks.ca/otr/ ). This is a really important feature
because no one should read your messages.
There were others with the same idea (links at the bottom).
Would be so great if it could support that important encryption standard.
Thanks for helping out!
Links:
https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/253452/comments/2
http://lists.cypherpunks.ca/pipermail/otr-users/2008-September/001479.html
http://bugs.freedesktop.org/show_bug.cgi?id=16891
To manage notifications about this bug go to:
https://bugs.launchpad.net/empathy/+bug/296867/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
