(In reply to comment #17)
> Created attachment 100723 [details] [review]
> Rotate documents correctly
>
> Hi,
>
> I'm sorry for my late response, I was super busy with something else.
No problem!
> (In reply to comment #15)
> > Comment on attachment 99331 [details] [review] [review]
> > Rotate documents correctly
> >
> > Review of attachment 99331 [details] [review] [review]:
> > -----------------------------------------------------------------
> >
> > This looks good to me, except the confusing NONE/LANDSCAPE thing. Adrian,
> > does the PostScript part looks good to you?
> >
> > ::: libspectre/spectre-device.c
> > @@ +206,4 @@
> > > return SPECTRE_STATUS_RENDER_ERROR;
> > > }
> > >
> > > + if (rc->orientation == NONE || rc->orientation == LANDSCAPE) {
> >
> > Why NONE and LANDSCAPE? shouldn't we invert width/height when orientation is
> > LANDSCAPE and SEASCAPE? Ah, I know what's going on, you are using the
> > internal values of the parser (my fault, I think I suggested it) but
> > rc->orientation is actually a SpectreOrientation enum value, so you should
> > use SPECTRE_ORIENTATION_PORTRAIT || SPECTRE_ORIENTATION_REVERSE_PORTRAIT
> > that are 0 and 2 like NONE and LANDSCAPE in the internal parser.
> >
> > @@ +269,4 @@
> > > args[arg++] = "-dNOPLATFONTS";
> > >
> > > if (rc->width != -1 && rc->height != -1) {
> > > + if (rc->orientation == NONE || rc->orientation == LANDSCAPE) {
> >
> > Same here.
>
> My brain was probably on a vacation :). I've fixed this so that it uses the
> SPECTRE_ORIENTATION_PORTRAIT and SPECTRE_ORIENTATION_REVERSE_PORTRAIT.
:-)
> Regards
>
> Marek
Pushed to git master, thanks!
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to evince in Ubuntu.
https://bugs.launchpad.net/bugs/1242678
Title:
evince cannot render some EPS files
Status in Evince document viewer:
New
Status in GS-GPL - GPL Ghostscript:
Unknown
Status in libspectre:
Fix Released
Status in “evince” package in Ubuntu:
Invalid
Status in “ghostscript” package in Ubuntu:
Invalid
Status in “gnuplot” package in Ubuntu:
Invalid
Status in “libspectre” package in Ubuntu:
Fix Released
Status in “evince” source package in Trusty:
Invalid
Status in “ghostscript” source package in Trusty:
Invalid
Status in “gnuplot” source package in Trusty:
Invalid
Status in “libspectre” source package in Trusty:
In Progress
Bug description:
I upgraded to Ubuntu Saucy,
evince cannot render EPS files generated by gnuplot.
(Just show an empty page.)
[how to reproduce]
1. Generate an EPS file using gnuplot by executing the following command.
$ gnuplot -e "set terminal postscript; set output 'test.eps'; plot x;"
2. Open the file "test.eps" just created.
$ evince "test.eps"
The following are what evince writes to the terminal.
(evince:24176): EvinceDocument-CRITICAL **: ev_document_get_n_pages:
assertion 'EV_IS_DOCUMENT (document)' failed
(evince:24176): Gtk-WARNING **: drawing failure for widget `EvView':
invalid matrix (not invertible)
(evince:24176): Gdk-CRITICAL **: gdk_pixbuf_get_from_surface:
assertion 'width > 0 && height > 0' failed
(evince:24176): Gdk-CRITICAL **: gdk_pixbuf_get_from_surface:
assertion 'width > 0 && height > 0' failed
3. Then evince just shows an empty (white) page.
===
If i rotate 90 or -90 degree by pressing Ctrl+Left or Ctrl+Right key,
evince can show this file correctly.
===
Okular, GIMP, inkscape and gs can show this EPS file.
(may be rotated 90 degree, however)
[Impact]
With the default viewer for PostrScript and EPS files, many files do
not display and produce errors/warnings. Users usually do not know
that they can visualize these files by rotating the page and rotated
it is also not in a very useful orientation.
[Test Case]
Display the attached EPS file with evince or follow the steps under
"how to reproduce" above. Rotate the page via Ctrl+Left or Ctrl+Right
and the image is only visible for two of the four orientations. Withe
the proposed package the problem get solved. The image is visible in
all the four orientations.
[Regression Potential]
Low, as tested with various files and reviewed by several upstream
developers.
ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: evince 3.10.0-0ubuntu2
ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3
Uname: Linux 3.11.0-12-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.12.5-0ubuntu2
Architecture: amd64
Date: Mon Oct 21 21:23:15 2013
InstallationDate: Installed on 2013-09-07 (44 days ago)
InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Release amd64 (20130424)
MarkForUpload: True
SourcePackage: evince
UpgradeStatus: Upgraded to saucy on 2013-10-04 (16 days ago)
To manage notifications about this bug go to:
https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
