Public bug reported:

In file /plugins/common/gsd-input-helper.c in function
run_custom_command the variable exit_status doesn't contain the exit
status of the process, so the statement "return (exit_status == 1);" is
wrong.

The documentation 
(https://developer.gnome.org/glib/stable/glib-Spawning-Processes.html#g-spawn-sync)
 says:
exit_status    return location for child exit status, as returned by waitpid(), 
or NULL.

And in the documentation of waitpid (http://linux.die.net/man/2/waitpid)
exit_status is described.

You have to do something like this:
if (WIFEXITED(exit_status) == FALSE) {
    return FALSE;
}
return (WEXITSTATUS(exit_status) == 1);

** Affects: gnome-settings-daemon (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-settings-daemon in Ubuntu.
https://bugs.launchpad.net/bugs/1339244

Title:
  Comparison of exit_status in run_custom_command is wrong

Status in “gnome-settings-daemon” package in Ubuntu:
  New

Bug description:
  In file /plugins/common/gsd-input-helper.c in function
  run_custom_command the variable exit_status doesn't contain the exit
  status of the process, so the statement "return (exit_status == 1);"
  is wrong.

  The documentation 
(https://developer.gnome.org/glib/stable/glib-Spawning-Processes.html#g-spawn-sync)
 says:
  exit_status    return location for child exit status, as returned by 
waitpid(), or NULL.

  And in the documentation of waitpid
  (http://linux.die.net/man/2/waitpid) exit_status is described.

  You have to do something like this:
  if (WIFEXITED(exit_status) == FALSE) {
      return FALSE;
  }
  return (WEXITSTATUS(exit_status) == 1);

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1339244/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to