Created attachment 8584346 Unified patch (code + test changes + twice revised new test)
Thank you very much for the review and all the additional explanation. I hope I could address your questions in additional comments in the test. Sadly switching from "mousedown/up" to "click" as you had suggested makes the test fail with: failed | uncaught exception - NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMWindowUtils.sendMouseEvent] at chrome://specialpowers/content/specialpowersAPI.js:161 This is actually the only test I intended to submit ;-) This is for the case where the user clicks beyond the end of the line. There are two tests already which I had to adapt to the new selection behaviour which test the moving to the end (editor/libeditor/tests/test_selection_move_commands.xul) and moving from the subsequent line using left arrow (layout/generic/test/test_movement_by_characters.html). If you wanted to be really purist a test with a "div contenteditable" could be added where an empty line is first filled with some text, which is then removed so the range becomes empty. The code caters for this case. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/584632 Title: composer changes font mid email Status in Mozilla Thunderbird Mail and News: Confirmed Status in thunderbird package in Ubuntu: Confirmed Bug description: Binary package hint: thunderbird As I'm typing my emails in Thunderbird, I can see what appears to be a font size change on screen, normally in the second line of text. The second line appear smaller than the first. It's barely perceptible, so half them time I think I am imagining it. Well, I've started Bccing to myself to check, and the emails I am receiving from myself are not only a different size, they're also a different font. Composer starts in some default serif, and by the second line is sans. I'd bee glad to email someone viz thunderbird, and also send along a screenshot of how it looks while I am typing. Thanks. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
