Public bug reported:

  CC       lnx_apm.lo
hw/xfree86/os-support/linux/lnx_apm.c: In function 'xf86OSPMOpen':
hw/xfree86/os-support/linux/lnx_apm.c:153:1: error: control reaches end of 
non-void function [-Werror=return-type]
 }
 ^
cc1: some warnings being treated as errors
Makefile:660: recipe for target 'lnx_apm.lo' failed
make: *** [lnx_apm.lo] Error 1

In lnx_apm.c file:

#ifdef HAVE_ACPI
    /* Favour ACPI over APM, but only when enabled */

    if (!xf86acpiDisableFlag)
        ret = lnxACPIOpen();

    if (!ret)
#endif
#ifdef HAVE_APM
        ret = lnxAPMOpen();
#endif

I think it means

#ifdef HAVE_ACPI
    /* Favour ACPI over APM, but only when enabled */

    if (!xf86acpiDisableFlag)
        ret = lnxACPIOpen();
#endif
#ifdef HAVE_APM
    if (!ret)
        ret = lnxAPMOpen();
#endif

** Affects: xorg-server (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to xorg-server in Ubuntu.
https://bugs.launchpad.net/bugs/1622488

Title:
  --disable-linux-apm and compile hw/xfree86/os-support/linux/lnx_apm.c

Status in xorg-server package in Ubuntu:
  New

Bug description:
    CC       lnx_apm.lo
  hw/xfree86/os-support/linux/lnx_apm.c: In function 'xf86OSPMOpen':
  hw/xfree86/os-support/linux/lnx_apm.c:153:1: error: control reaches end of 
non-void function [-Werror=return-type]
   }
   ^
  cc1: some warnings being treated as errors
  Makefile:660: recipe for target 'lnx_apm.lo' failed
  make: *** [lnx_apm.lo] Error 1

  In lnx_apm.c file:

  #ifdef HAVE_ACPI
      /* Favour ACPI over APM, but only when enabled */

      if (!xf86acpiDisableFlag)
          ret = lnxACPIOpen();

      if (!ret)
  #endif
  #ifdef HAVE_APM
          ret = lnxAPMOpen();
  #endif

  I think it means

  #ifdef HAVE_ACPI
      /* Favour ACPI over APM, but only when enabled */

      if (!xf86acpiDisableFlag)
          ret = lnxACPIOpen();
  #endif
  #ifdef HAVE_APM
      if (!ret)
          ret = lnxAPMOpen();
  #endif

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1622488/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to