Great, thanks Chris!

Note: I am not a JS expert, so my suggested replacement in comment 0
might not be exactly right for all cases of this pattern.  (I believe
it's correct for code that's iterating over a JS array, but the
semantics might be slightly different for other structures, e.g. whether
you're iterating over keys vs. values, etc.  This definitely merits a
sanity-check test (e.g. logging each iterated entry before/after the
change) to be sure the conversion is valid.)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to ubufox in Ubuntu.
https://bugs.launchpad.net/bugs/1648649

Title:
  Ubufox is broken in Firefox Nightly, due to using no-longer-supported
  "for each" syntax.  Error console now shows "SyntaxError: missing (
  after for  UpdateNotifier.js:217:8"

Status in ubufox package in Ubuntu:
  New

Bug description:
  Firefox Nightly (53) no longer supports the non-standard "for each"
  looping construct, as of
  https://bugzilla.mozilla.org/show_bug.cgi?id=1293305

  Unfortunately, ubufox uses this construct, which causes problems as shown in 
the error console at startup:
  > SyntaxError: missing ( after for     UpdateNotifier.js:217:8
  > SyntaxError: missing ( after for     utils.jsm:217:8

  
  Fortunately, it's easy to fix! Just replace code like this...
  > for each (let k in [...])
  ...with code like this:
  > for (let k of [...])

  Note: I also filed this in Mozilla's bug-tracker (under Tech Evangelism | 
Add-ons) here:
   https://bugzilla.mozilla.org/show_bug.cgi?id=1322551

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubufox/+bug/1648649/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to