This debdiff is for xenial. # required by platform-add-a-new-function-nmp_utils_open_sysctl.patch, platform-refactor-nmp_utils_sysctl_open_netdir.patch and all-use-O_CLOEXEC-for-file-descriptors.patch. core-add-utils-for-file-handling.patch
# required by platform-wifi-use-nmp_utils_open_sysctl-to-check-if-.patch. platform-refactor-wifi_utils_is_wifi-not-to-pass-sys.patch # The following patches (backported from 1.4) are directly from https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=ea944d5b4c5eac192a95cf0397459df24fee39cf shared-add-nm_auto_close-and-nm_auto_fclose.patch device-wwan-use-nm_auto_close-instead-of-gs_fd_close.patch platform-add-a-new-function-nmp_utils_open_sysctl.patch platform-wifi-use-nmp_utils_open_sysctl-to-check-if-.patch platform-refactor-nmp_utils_sysctl_open_netdir.patch all-use-O_CLOEXEC-for-file-descriptors.patch Some header files are changed such as src/nm-core-utils.h, src/platform/wifi/wifi-utils.h, shared/nm-utils/nm-macros-internal.h and src/platform/nm-platform-utils.h. But only src/platform/wifi/wifi-utils.h changed the interface a little bit while other only added some new interfaces. src/platform/wifi/wifi-utils.h's change is like the following. # from platform-refactor-wifi_utils_is_wifi-not-to-pass-sys.patch -gboolean wifi_utils_is_wifi (const char *iface, const char *sysfs_path); +gboolean wifi_utils_is_wifi (const char *iface); # from platform-wifi-use-nmp_utils_open_sysctl-to-check-if-.patch -gboolean wifi_utils_is_wifi (const char *iface); +gboolean wifi_utils_is_wifi (int ifindex, const char *ifname); However these header files are just internal and they should not affect outside. ** Patch added: "network-manager_1.2.6-0ubuntu0.16.04.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1647283/+attachment/4914530/+files/network-manager_1.2.6-0ubuntu0.16.04.2.debdiff -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to network-manager in Ubuntu. https://bugs.launchpad.net/bugs/1647283 Title: WiFi being detected as ethernet when race condition on renaming for persistent name Status in HWE Next: Fix Released Status in NetworkManager: Fix Released Status in OEM Priority Project: In Progress Status in OEM Priority Project xenial series: In Progress Status in network-manager package in Ubuntu: Fix Released Bug description: Forwarded https://bugzilla.gnome.org/show_bug.cgi?id=775613 Version: NetworkManager 1.4.2 This bug happens after power-on with probability about 1/50. That means we need to reboot about 50 times to get into the buggy situation. "nmcli d" shows the device type is ethernet: DEVICE TYPE STATE CONNECTION wlp1s0 ethernet unavailable -- lo loopback unmanaged -- The bug starts from a race condition. But it is not the root cause. I've also attach 2 logs. One is in good situation. Another is in bad situation. This log is generated by applying a "log patch" to network-manager 1.4.2 so we can see more stuff. In the bad situation. The bug starts with race condition. But the race condition is not the root cause. The race condition is: * During the renaming from "wlan0" to "wlp1s0". "wlan0" disappeared. * Inside the NM, it is still using "wlan0" in "_linktype_get_type()". * Since /sys/class/net/wlan0/uevent is disappeared. so the type matching failed in _linktype_get_type(). * Also wifi_utils_is_wifi() failed to because /sys/class/net/wlan0 disappeared. * And finally, devtype and kind are both NULL, so it returns NM_LINK_TYPE_ETHERNET for wlan0. Later, wlan0 is renamed to wlp1s0, and it seems to me that the Object inherit the type so it is still type ethernet. But from the log, I saw _linktype_get_type() is called several times later and return the correct type (wifi). But just, "nmcli d" still shows type ethernet. I'm wondering if we are missing to update the type in the Object created after renaming and re-detecting the type. fix need landing LP: #1645698 To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/1647283/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
