Comment on attachment 575899 Bug 635918 Part 1 - Make nsISound::Play use libcanberra on Linux rather than esound (v3)
I didn't know the nsLocalFile implementation was thread safe, but yay it is: http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsLocalFileUnix.cpp#287 >+ nsILocalFile* forget() { >+ nsILocalFile *tmp; >+ mFile.forget(&tmp); >+ return tmp; >+ } Usually we have already_AddRefed<T> return values for forget() methods in scoped refcounting systems so this is a bit different if the result is ever assigned to another similar auto-refcount object. The return value is in fact not used, so use "mFile.forget()" to simplify things and either return its result directly or make the function return type void. >+ operator void*() { return mFile; } Making this "operator nsILocalFile*()" would be more explicit. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/732572 Title: New Mail Notification Sound does not play in Natty Status in Mozilla Thunderbird Mail and News: In Progress Status in “thunderbird” package in Ubuntu: Triaged Status in “thunderbird” source package in Oneiric: Triaged Bug description: Binary package hint: thunderbird After setting the preference to play a .wav file and selecting a working .wav file, it will not play by ether: 1. Clicking the Play button in the preference dialog 2. Receiving a new email Expected result is that it should play the selected file. ProblemType: Bug DistroRelease: Ubuntu 11.04 Package: thunderbird 3.1.9+nobinonly-0ubuntu1 ProcVersionSignature: Ubuntu 2.6.38-5.32-generic-pae 2.6.38-rc6 Uname: Linux 2.6.38-5-generic-pae i686 Architecture: i386 Date: Thu Mar 10 13:23:55 2011 EcryptfsInUse: Yes InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha i386 (20110302) ProcEnviron: LANGUAGE=en_US:en PATH=(custom, user) LANG=en_US.UTF-8 SHELL=/bin/bash SourcePackage: thunderbird UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/732572/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
