Doko asked me to look at the package and it seems OK to me on a quick glance. (Only spent a few minutes, let me know if you'd like a deeper review!)
On the packaging side, I'm a bit surprised at the use of go:generate to create the shared lib but it works I guess. Another thing that's more on the taste side is that rather than knowing that debhelper puts build artefacts in obj-$(DEB_HOST_GNU_TYPE), I prefer to pass --builddirectory=_build or whatever to dh. I'd generally be happier if the vendor directory wasn't in the source tarball at all (which would also get you out of updating debian/copyright :-p). I think you can do this by putting tar-ignore =ubuntu-report/vendor into debian/source/options? (Side comment: why is debian/ in .gitignore??) -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to ubuntu-report in Ubuntu. https://bugs.launchpad.net/bugs/1759540 Title: [MIR] ubuntu-report: send telemetry data to ubuntu server Status in ubuntu-report package in Ubuntu: Incomplete Bug description: Note that only the C library ("libsysmetrics1") and the command line ("ubuntu-report") packages are needed in main (we should also promote "libsysmetrics-dev" package, even if not necessary). We don't need the Go API "golang-github-ubuntu-ubuntu-report-dev" which has many go package dependencies in universe. [Availability] Available and built on all archs. [Rationale] We want to provide telemetry upload features, collected by ubiquity, do-release-upgrader and that package in ubnutu 18.04. see https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1755456 for more rationales and details. [Security] No security issue reported, as brand new package. The package do a POST message over https to an ubuntu server, data being sent are really limited to garantee anynomous informations. See example of what is sent on https://github.com/ubuntu/ubuntu-report README. [Quality assurance] The canonical desktop team is the upstream maintainer and will continue maintening it. Upstream has CI built-in on every commit + coverage report. The package build and runs (currently) 243 tests from unit to integration tests. Autopkgtests ensuring that building works and tests still pass is also provided. In addition the documentation and C API are continously strongly tested (with examples extracted from the documentation, built, linked against a on-demand generated C library, and tests ran against it). [Dependencies] Upstream is using a vendor/ directory, but the ubuntu package remove it on build and use the distribution packaged build-deps equivalent. No runtime dep in the 3 packages that needs to be promoted. [Standards compliance] Package follow latest debian packaging standard compliant. No lintian override files, and binaries/packages follows Debian standard FHS. Note that there is no .symbols file as the generated C API export internal symbols (starting with _) which names contains a hash dependant of the source file, and per arch specific. The exported symbols from the public API have a stable name though: https://godoc.org/github.com/ubuntu/ubuntu-report/pkg/sysmetrics/C [Maintenance] Canonical desktop team being the usptream and downstream maintainer, strongly backed by tests, will follow bugs and maintenance. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1759540/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
