I am going to have a look at this soon.
On Wed, 15 Aug 2018 at 23:20, Steve Langasek <[email protected]>
wrote:
> Reviewing ubuntu-drivers-common in the queue, I notice:
>
> + if (!match) {
> + free(match);
>
> Surely no good can come of this call to free() and it should be omitted?
>
> The change to start before oem-config.service seems correct but has no
> associated bug linked. This looks to me like it should still go through
> the SRU verification process because it's unrelated to the other
> changes. (Also, it's not 100% obvious that the change is correct: for
> example, why does oem-config not provide display-manager.service? Why
> are there no interdependencies between oem-config's systemd units and
> display-manager.service?)
>
> The source package as uploaded appears to have a lot of cruft in various
> __pycache__ directories. This ought to be cleaned up.
>
> I'm going to go ahead and reject based on the missing bug reference for
> the oem-config.service change. If you think this is wrong, feel free to
> ping me on IRC to discuss.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1778011
>
> Title:
> SRU: PRIME Power Saving mode draws too much power
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1778011/+subscriptions
>
> Launchpad-Notification-Type: bug
> Launchpad-Bug: distribution=ubuntu; sourcepackage=gdm3; component=main;
> status=Fix Released; importance=High; assignee=
> [email protected];
> Launchpad-Bug: distribution=ubuntu;
> sourcepackage=nvidia-graphics-drivers-390; component=restricted; status=Fix
> Released; importance=High; [email protected];
> Launchpad-Bug: distribution=ubuntu; sourcepackage=nvidia-prime;
> component=main; status=Fix Released; importance=High; assignee=
> [email protected];
> Launchpad-Bug: distribution=ubuntu; sourcepackage=nvidia-settings;
> component=main; status=Fix Released; importance=High; assignee=
> [email protected];
> Launchpad-Bug: distribution=ubuntu; sourcepackage=ubuntu-drivers-common;
> component=main; status=Fix Released; importance=High; assignee=
> [email protected];
> Launchpad-Bug: distribution=ubuntu; distroseries=bionic;
> sourcepackage=gdm3; component=main; status=In Progress; importance=High;
> [email protected];
> Launchpad-Bug: distribution=ubuntu; distroseries=bionic;
> sourcepackage=nvidia-graphics-drivers-390; component=restricted; status=In
> Progress; importance=High; [email protected];
> Launchpad-Bug: distribution=ubuntu; distroseries=bionic;
> sourcepackage=nvidia-prime; component=main; status=In Progress;
> importance=High; [email protected];
> Launchpad-Bug: distribution=ubuntu; distroseries=bionic;
> sourcepackage=nvidia-settings; component=main; status=In Progress;
> importance=High; [email protected];
> Launchpad-Bug: distribution=ubuntu; distroseries=bionic;
> sourcepackage=ubuntu-drivers-common; component=main; status=In Progress;
> importance=High; [email protected];
> Launchpad-Bug-Information-Type: Public
> Launchpad-Bug-Private: no
> Launchpad-Bug-Security-Vulnerability: no
> Launchpad-Bug-Commenters: albertomilone andrebrait cantfind ilvipero
> janitor vorlon
> Launchpad-Bug-Reporter: Alberto Milone (albertomilone)
> Launchpad-Bug-Modifier: Steve Langasek (vorlon)
> Launchpad-Message-Rationale: Subscriber
> Launchpad-Message-For: albertomilone
>
--
Alberto Milone
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to nvidia-prime in Ubuntu.
https://bugs.launchpad.net/bugs/1778011
Title:
SRU: PRIME Power Saving mode draws too much power
Status in gdm3 package in Ubuntu:
Fix Released
Status in nvidia-graphics-drivers-390 package in Ubuntu:
Fix Released
Status in nvidia-prime package in Ubuntu:
Fix Released
Status in nvidia-settings package in Ubuntu:
Fix Released
Status in ubuntu-drivers-common package in Ubuntu:
Fix Released
Status in gdm3 source package in Bionic:
Fix Committed
Status in nvidia-graphics-drivers-390 source package in Bionic:
Incomplete
Status in nvidia-prime source package in Bionic:
In Progress
Status in nvidia-settings source package in Bionic:
In Progress
Status in ubuntu-drivers-common source package in Bionic:
In Progress
Bug description:
SRU Request:
[Impact]
Relying on the nouveau driver and on the vga switcheroo (to get around a
change in systemd LP: #1777099) caused increased power consumption, and slowed
down the switching process.
Furthermore, if the main X/Xwayland session was started by Gdm when
the nvidia driver was loaded, the session will keep the nvidia module
loaded, and prevent the system from switching off the dGPU. Also, the
nouveau driver will be loaded, if nvidia is not, and this can cause
problems to unsupported NVIDIA GPUs.
The solution involves the following changes:
1) Solving the problem in systemd (LP: #1777099)
2) Adding code in gpu-manager and in nvidia-prime to unload the nvidia
modules, and to allow the PCI device to sleep.
3) Making a slight change to the current patch in Gdm, used to call
the PRIME scripts before and after a Gdm session (so that gpu-manager
gets actually called on log out)
4) Adding code in gpu-manager to kill the main X/Xwayland session on
log out, if the session is preventing us from unloading the nvidia
driver. A new X/Xwayland session will be created after unload the
module.
5) Removing the systemd service that loads nouveau from the nvidia
packages.
[Test Case]
1) Enable the -proposed repository, and install the new
"ubuntu-drivers-common", nvidia drivers, nvidia-prime, and gdm3
2) Make sure the nvidia packages are installed, and enable performance mode
(if it is already enabled, call "sudo prime-select intel" first):
sudo prime-select nvidia
3) Restart your computer and attach your /var/log/gpu-manager.log. see
if the system boots correctly. If unsure, please attach your /var/log
/gpu-manager.log and /var/log/Xorg.0.log
4) Select power saving mode:
sudo prime-select intel
5) Log out and log back in
6) Check if the nvidia driver is still loaded:
lsmod | grep nvidia
[Regression Potential]
Low, as hybrid graphics support does not work correctly, and the changes only
affect this use case.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1778011/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
