Comment on attachment 8915954 Bug 143038 Make users can scroll contents horizontally with vertical wheel operation with a modifier
https://reviewboard.mozilla.org/r/186794/#review193228 Still r-, because I was surprised to see "expected: kScrollDown | kScrollLeft" in case there is both vertical and horizontal scrolling with modifier. Please explain or fix. ::: dom/events/test/window_wheel_default_action.html:1830 (Diff revision 2) > + > + const kTests = [ > + // Without modifier key, the default's action should be used. > + // I.e., vertical scroll is expected normally. > + { defaultActions: { > + default: 1, with_shift: 2, with_control: 3 What these numbers are? 1, 2, 3? Please add some comment ::: dom/events/test/window_wheel_default_action.html:1853 (Diff revision 2) > + deltaX: 0, deltaY: -1.0, > + lineOrPageDeltaX: 0, lineOrPageDeltaY: -1, > + shiftKey: false, ctrlKey: false, altKey: false }, > + expected: kScrollUp > + }, > + // If only the modifier to treat vertical wheel as horizontal scroll, I don't understand this sentence. ::: dom/events/test/window_wheel_default_action.html:1914 (Diff revision 2) > + deltaMultiplierX: 1.0, > + deltaMultiplierY: 1.0, > + event: { deltaMode: WheelEvent.DOM_DELTA_LINE, > + deltaX: 0, deltaY: 1.0, > + lineOrPageDeltaX: 0, lineOrPageDeltaY: 1, > + shiftKey: true, ctrlKey: true, altKey: false }, Oh, modifier in the JS object isn't about the event but about the pref. Could you document that somewhere ::: dom/events/test/window_wheel_default_action.html:1981 (Diff revision 2) > + deltaX: 0, deltaY: -1.0, > + lineOrPageDeltaX: 0, lineOrPageDeltaY: -1, > + shiftKey: true, ctrlKey: true, altKey: false }, > + expected: kScrollUp > + }, > + // If the wheel is operated diagonally, shouldn't treat the deltaY as This sounds wrong. If the pref is set, and modifier is pressed, why should viewport scroll ever horizontally? I don't see such behavior in Chrome on Windows ::: dom/events/test/window_wheel_default_action.html:2184 (Diff revision 2) > ["mousewheel.default.action.override_x", -1], > ["mousewheel.with_shift.action", 2], // history > ["mousewheel.with_shift.action.override_x", -1], > ["mousewheel.with_control.action", 3], // zoom > - ["mousewheel.with_control.action.override_x", -1]]}, > + ["mousewheel.with_control.action.override_x", -1], > + ["mousewheel.modifier_to_treat_vertical_wheel_as_horizontal_scroll", > 0]]}, I don't understand this. Why 0? Doesn't that disable the feature. ::: modules/libpref/init/all.js:2759 (Diff revision 2) > +// to one of 16 (Shift), 17 (Ctrl), 18 (Alt/Option) and 224 (Command), the > +// corresponding modifier key with vertical scroll is treated as horizontal > +// scroll. Note that this setting may override the action set by > +// "mousewheel.with_*.action" and mousewheel.with_*.action.override_x. E.g., > +// when this is set to 16 (Shift) and "mousewheel.with_shift.action" is set > to > +// 2 (History Navigation), try to scrolling vertically with Shift key causes s/try to// ::: widget/MouseEvents.h:597 (Diff revision 2) > mLineOrPageDeltaX : mLineOrPageDeltaY; > } > > + void SwapDeltaXAndDeltaY() > + { > + auto tmpDelta = mDeltaX; I guess you could use std::swap here -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1228250 Title: [Shift + Mouse-Scroll-Wheel] Does NOT Scroll Horizontally Status in Mozilla Firefox: Fix Released Status in firefox package in Ubuntu: Fix Released Bug description: In Chromium, I can scroll horizontally using my mouse-wheel by holding down the shift key while scrolling the mouse wheel. Firefox is missing this very convenient page-navigation short-cut. Use Case: As my eyes age, I find myself always scaling up the web pages I read (by holding down crtl and scrolling my mouse wheel). Doing this, often makes the page exceed the width of my monitor (hiding the right-side of the text I want to read) and produces a horizontal scroll bar at the bottom of the page. At this point, since I've already used ctrl-scroll-mouse-wheel to magnify the page, it would be wonderful if I could use shift-scroll- mouse-wheel to horizontally-scroll the magnified page and therefore center the (previously cropped) text that I am wanting to read. ProblemType: Bug DistroRelease: Ubuntu 13.04 Package: firefox 24.0+build1-0ubuntu0.13.04.1 ProcVersionSignature: Ubuntu 3.8.0-30.44-generic 3.8.13.6 Uname: Linux 3.8.0-30-generic x86_64 NonfreeKernelModules: wl AddonCompatCheckDisabled: False ApportVersion: 2.9.2-0ubuntu8.3 Architecture: amd64 AudioDevicesInUse: USER PID ACCESS COMMAND /dev/snd/controlC0: lonnie 2161 F.... pulseaudio /dev/snd/pcmC0D0p: lonnie 2161 F...m pulseaudio BrokenPermissions: sessionstore.bak (0o600, wrong owner) BuildID: 20130911155223 Channel: Unavailable Date: Fri Sep 20 11:02:07 2013 ForcedLayersAccel: False IfupdownConfig: # interfaces(5) file used by ifup(8) and ifdown(8) auto lo iface lo inet loopback InstallationDate: Installed on 2013-09-06 (14 days ago) InstallationMedia: Ubuntu 13.04 "Raring Ringtail" - Release amd64 (20130424) IpRoute: default via 192.168.24.1 dev eth0 proto static 192.168.24.0/24 dev eth0 proto kernel scope link src 192.168.24.198 metric 1 MarkForUpload: True PrefSources: prefs.js [Profile]/extensions/{b9db16a4-6edc-47ec-a1f4-b86292ed211d}/defaults/preferences/prefs-dwhelper.js ProcEnviron: TERM=xterm PATH=(custom, no user) XDG_RUNTIME_DIR=<set> LANG=en_US.UTF-8 SHELL=/bin/bash Profiles: Profile0 (Default) - LastVersion=24.0/20130911155223 (In use) RelatedPackageVersions: google-talkplugin 4.5.3.0-1 icedtea-7-plugin 1.3.2-1ubuntu1.1 totem-mozilla 3.6.3-0ubuntu6 rhythmbox-mozilla 2.98-0ubuntu5 RunningIncompatibleAddons: False SourcePackage: firefox UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 04/14/2011 dmi.bios.vendor: Dell Inc. dmi.bios.version: A09 dmi.board.name: 0P792H dmi.board.vendor: Dell Inc. dmi.board.version: A09 dmi.chassis.type: 8 dmi.chassis.vendor: Dell Inc. dmi.chassis.version: A09 dmi.modalias: dmi:bvnDellInc.:bvrA09:bd04/14/2011:svnDellInc.:pnStudio1737:pvrA09:rvnDellInc.:rn0P792H:rvrA09:cvnDellInc.:ct8:cvrA09: dmi.product.name: Studio 1737 dmi.product.version: A09 dmi.sys.vendor: Dell Inc. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1228250/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
