Comment on attachment 8956310
Bug 440908 - Add support for `sticky` and `locked` attributes to default prefs.

https://reviewboard.mozilla.org/r/225184/#review231212

::: modules/libpref/Preferences.cpp:3982
(Diff revision 1)
> -    Preferences::GetCString(kChannelPref, updateChannelPrefValue,
> -                            PrefValueKind::Default);
> +    Preferences::GetCString(
> +      kChannelPref, updateChannelPrefValue, PrefValueKind::Default);
>      releaseCandidateOnBeta = updateChannelPrefValue.EqualsLiteral("beta");
>    }
>  
>    if (!strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "nightly") ||
>        !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "aurora") ||
> -      !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "beta") ||
> +      !strcmp(NS_STRINGIFY(MOZ_UPDATE_CHANNEL), "beta") || developerBuild ||

clang-format changed its mind, I guess?

::: modules/libpref/parser/src/lib.rs:282
(Diff revision 1)
>  struct KeywordInfo {
>    string: &'static [u8],
>    token: Token,
>  }
>  
> -const KEYWORD_INFOS: &[KeywordInfo; 5] = &[
> +const KEYWORD_INFOS: &[KeywordInfo; 7] = &[

In passing, AFAIK, this could actually me [KeywordInfo; 7] (without the
ref)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/623844

Title:
  lockpref not honored in /etc/thunderbird/pref/thunderbird.js

Status in Mozilla Thunderbird:
  Fix Released
Status in thunderbird package in Ubuntu:
  New

Bug description:
  Binary package hint: thunderbird

  appended /etc/thunderbird/pref/thunderbird.js with the following line:
  lockpref("app.update.enabled", false);

  When starting Thunderbird and checking the config app.update.enabled
  is set to false, but can be edited by the user.

  ProblemType: Bug
  DistroRelease: Ubuntu 10.04
  Package: thunderbird 3.0.6+build2+nobinonly-0ubuntu0.10.04.1
  ProcVersionSignature: Ubuntu 2.6.32-24.39-generic 2.6.32.15+drm33.5
  Uname: Linux 2.6.32-24-generic x86_64
  Architecture: amd64
  Date: Wed Aug 25 09:58:43 2010
  InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
  ProcEnviron:
   PATH=(custom, no user)
   LANG=de_DE.utf8
   SHELL=/bin/bash
  SourcePackage: thunderbird

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to