Launchpad has imported 33 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1403483.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2017-09-27T08:49:57+00:00 Jhofmann-d wrote: Created attachment 8912611 Screen Shot 2017-09-27 at 10.46.56.png See screenshot, the first tab separator should have the same height as the other separators. We forgot to do that in bug 1390025. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/0 ------------------------------------------------------------------------ On 2017-09-29T08:50:07+00:00 Jhofmann-d wrote: Let's do this after bug 1391539, otherwise we'll have to file another bug to adjust the height of this border when hovering (I'm happy to pick it up once bug 1391539 is done). Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/1 ------------------------------------------------------------------------ On 2017-10-09T10:39:42+00:00 Jhofmann-d wrote: *** Bug 1406681 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/2 ------------------------------------------------------------------------ On 2017-10-09T16:42:45+00:00 Mehmet-sahin wrote: Created attachment 8916677 Bildschirmfoto 2017-10-09 um 18.39.58.png Hi Johann, I noticed that the overflow separator has also the bug. Please see the screenshot. Thanks. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/3 ------------------------------------------------------------------------ On 2017-10-10T20:18:27+00:00 Nhnt11 wrote: Created attachment 8917126 Bug 1403483 - Set a border on the first tab instead of at the end of the pre-tabs drag space. Review commit: https://reviewboard.mozilla.org/r/188134/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/188134/ Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/4 ------------------------------------------------------------------------ On 2017-10-10T20:36:46+00:00 Nhnt11 wrote: Comment on attachment 8917126 Bug 1403483 - Set a border on the first tab instead of at the end of the pre-tabs drag space. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188134/diff/1-2/ Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/5 ------------------------------------------------------------------------ On 2017-10-10T20:38:36+00:00 Nhnt11 wrote: This works well for me at the moment on current central, but I need to confirm with Johann whether some changes around this code he was talking about have landed already or not. Also, I'm not entirely sure this works for RTL, I'm going to investigate this tomorrow. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/6 ------------------------------------------------------------------------ On 2017-10-10T20:39:13+00:00 Nhnt11 wrote: Hmm, and I think I need to make the Windows-specific selector account for the menubar as well as maximized mode. Canceling review for now. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/7 ------------------------------------------------------------------------ On 2017-10-19T11:59:03+00:00 Dao+bmo wrote: *** Bug 1408953 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/8 ------------------------------------------------------------------------ On 2017-10-28T02:15:39+00:00 Nhnt11 wrote: Created attachment 8923047 Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs whitespace. Review commit: https://reviewboard.mozilla.org/r/194262/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/194262/ Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/9 ------------------------------------------------------------------------ On 2017-10-28T02:20:28+00:00 Nhnt11 wrote: Comment on attachment 8923047 Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs whitespace. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194262/diff/1-2/ Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/10 ------------------------------------------------------------------------ On 2017-10-28T02:24:39+00:00 Nhnt11 wrote: Dão, the only problem (as far as I can tell) with this patch is that there is no tab separator before the first non-pinned tab when the tabstrip is overflowing. A CSS-only solution might be to use a selector like .tabbrowser-tab[pinned] + .tabbrowser-tab:not([pinned]), but I worry about hidden tabs in between. Do you think this would be an OK solution or should we try and add an attribute to the first visible non- pinned tab in JavaScript for styling convenience? Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/11 ------------------------------------------------------------------------ On 2017-10-28T13:09:52+00:00 Nhnt11 wrote: Comment on attachment 8923047 Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs whitespace. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194262/diff/2-3/ Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/12 ------------------------------------------------------------------------ On 2017-10-28T13:10:36+00:00 Nhnt11 wrote: TODO: Add a rule to hide the first tab separator when sizemode != normal on Windows. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/13 ------------------------------------------------------------------------ On 2017-10-30T00:08:33+00:00 Nhnt11 wrote: Comment on attachment 8923047 Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs whitespace. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194262/diff/3-4/ Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/14 ------------------------------------------------------------------------ On 2017-10-30T00:10:02+00:00 Nhnt11 wrote: (In reply to Nihanth Subramanya [:nhnt11] from comment #13) > TODO: Add a rule to hide the first tab separator when sizemode != normal on > Windows. Latest patch takes care of this. Need to investigate if Linux needs a similar rule. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/15 ------------------------------------------------------------------------ On 2017-11-01T11:23:10+00:00 Dao+bmo wrote: Comment on attachment 8923047 Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs whitespace. https://reviewboard.mozilla.org/r/194262/#review200420 It's not clear to me why this patch moves the border away fron the pre- tabs whitespace. Why can we not just fix that border's height? Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/16 ------------------------------------------------------------------------ On 2017-11-07T12:40:18+00:00 Nhnt11 wrote: (In reply to Dão Gottwald [::dao] from comment #16) > Comment on attachment 8923047 > Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs > whitespace. > > https://reviewboard.mozilla.org/r/194262/#review200420 > > It's not clear to me why this patch moves the border away fron the pre-tabs > whitespace. Why can we not just fix that border's height? The border styling needs to change when the first tab is hovered/selected: is there an easy way to style the border of the pre- tabs whitespace depending on the :hover/visuallyselected state of the first tab? I don't see one. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/17 ------------------------------------------------------------------------ On 2017-11-10T12:26:29+00:00 Jhofmann-d wrote: In support of Nihanths current solution, it's probably what we need to do to resolve bug 1403520 as well. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/18 ------------------------------------------------------------------------ On 2017-11-10T12:27:16+00:00 Jhofmann-d wrote: I'm setting this to block bug 1403520 for now, as we probably shouldn't act there without solving this first. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/19 ------------------------------------------------------------------------ On 2017-12-04T12:38:19+00:00 Jhofmann-d wrote: Hey folks, is there anything we can do to resolve this anytime soon? I'm happy to take the review if you're busy right now, Dão. Thanks! Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/20 ------------------------------------------------------------------------ On 2017-12-04T23:54:15+00:00 Nhnt11 wrote: Comment on attachment 8923047 Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs whitespace. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194262/diff/4-5/ Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/21 ------------------------------------------------------------------------ On 2017-12-04T23:58:17+00:00 Nhnt11 wrote: (In reply to Nihanth Subramanya [:nhnt11] from comment #21) > Comment on attachment 8923047 > Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs > whitespace. > > Review request updated; see interdiff: > https://reviewboard.mozilla.org/r/194262/diff/4-5/ Rebased and added the sizemode != normal rule for Linux (re. comment 15 quoted below) (In reply to Nihanth Subramanya [:nhnt11] from comment #15) > (In reply to Nihanth Subramanya [:nhnt11] from comment #13) > > TODO: Add a rule to hide the first tab separator when sizemode != normal on > > Windows. > > Latest patch takes care of this. Need to investigate if Linux needs a > similar rule. (In reply to Johann Hofmann [:johannh] from comment #20) > Hey folks, is there anything we can do to resolve this anytime soon? I'm > happy to take the review if you're busy right now, Dão. > > Thanks! Dão, re-flagged you for r?, let me know if I should redirect this to Johann. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/22 ------------------------------------------------------------------------ On 2018-05-14T13:13:09+00:00 Nhnt11 wrote: Created attachment 8975470 Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs whitespace. Review commit: https://reviewboard.mozilla.org/r/243752/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/243752/ Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/23 ------------------------------------------------------------------------ On 2018-05-30T07:57:46+00:00 Jhofmann-d wrote: Comment on attachment 8975470 Bug 1403483 - Show tab separator on first tab instead of on the pre-tabs whitespace. https://reviewboard.mozilla.org/r/243752/#review253754 This is pretty fiddly to get right but I feel like you did a great job, although I'm not as immersed into this code as I was half a year ago :) Generally this looks pretty good to me. I have one small complaint: I don't think the separator looks good on Windows 7 (non-maximized) like this. I can attach a screenshot. Considering that we're both not really working on tabs full-time anymore it's probably a good idea not to defer that to a follow-up bug. We could consider trying to entirely hide the separator on Windows 7 (would need to check how that looks with light/dark theme, too). Let me know if you want to borrow my VM for that... Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/24 ------------------------------------------------------------------------ On 2018-05-30T07:59:29+00:00 Jhofmann-d wrote: Created attachment 8981781 Windows 7 Sorry for the small image, might have to zoom in. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/25 ------------------------------------------------------------------------ On 2018-05-30T11:33:48+00:00 Laszlo-bialis wrote: *** Bug 1464373 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/26 ------------------------------------------------------------------------ On 2019-03-21T19:41:35+00:00 Smlombardi wrote: I see the same issue on the Mac, 10.14.3 with FF developer edition 67.0b3  Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/27 ------------------------------------------------------------------------ On 2019-03-27T15:50:30+00:00 Dao+bmo wrote: *** Bug 1538767 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/28 ------------------------------------------------------------------------ On 2019-07-23T10:54:18+00:00 Dao+bmo wrote: *** Bug 1567705 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/36 ------------------------------------------------------------------------ On 2019-07-23T13:13:31+00:00 Dao+bmo wrote: *** Bug 1567246 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/40 ------------------------------------------------------------------------ On 2019-07-24T17:58:40+00:00 Lhenry wrote: Is this still something we want to land? We have a couple of duplicates so I think it's an issue that bothers users and it's also marked P1. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/42 ------------------------------------------------------------------------ On 2019-07-25T07:03:17+00:00 Dao+bmo wrote: (In reply to Liz Henry (:lizzard) (use needinfo) from comment #31) > Is this still something we want to land? It's not ready to land, might not be even close. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1824409/comments/43 ** Changed in: firefox Status: Unknown => In Progress ** Changed in: firefox Importance: Unknown => Medium -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1824409 Title: Client side decoration in Firefox with Pop theme has a slight imperfection Status in Mozilla Firefox: In Progress Status in firefox package in Ubuntu: Triaged Bug description: With Firefox new client-side decoration, when using Pop theme, there is a small white line upon the first tab that looks unclean. Also, don't use the whole title bar height, which might look cleaner, or not :-) ProblemType: Bug DistroRelease: Ubuntu 19.04 Package: firefox 66.0.3+build1-0ubuntu1 ProcVersionSignature: Ubuntu 5.0.0-8.9-generic 5.0.1 Uname: Linux 5.0.0-8-generic x86_64 NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair AddonCompatCheckDisabled: False ApportVersion: 2.20.10-0ubuntu26 Architecture: amd64 AudioDevicesInUse: USER PID ACCESS COMMAND /dev/snd/controlC1: franck 3795 F.... pulseaudio /dev/snd/pcmC1D0c: franck 3795 F...m pulseaudio /dev/snd/controlC0: franck 3795 F.... pulseaudio BuildID: 20190410124846 Channel: Unavailable CurrentDesktop: GNOME Date: Thu Apr 11 20:44:57 2019 EcryptfsInUse: Yes Extensions: extensions.sqlite corrupt or missing ForcedLayersAccel: False IfupdownConfig: # interfaces(5) file used by ifup(8) and ifdown(8) auto lo iface lo inet loopback IncompatibleExtensions: Unavailable (corrupt or non-existant compatibility.ini or extensions.sqlite) IpRoute: default via 10.0.0.1 dev enp0s25 proto dhcp metric 100 default via 10.0.0.1 dev wlp3s0 proto dhcp metric 600 10.0.0.0/24 dev enp0s25 proto kernel scope link src 10.0.0.14 metric 100 10.0.0.0/24 dev wlp3s0 proto kernel scope link src 10.0.0.246 metric 600 10.204.48.0/24 dev lxdbr0 proto kernel scope link src 10.204.48.1 Locales: extensions.sqlite corrupt or missing PrefSources: prefs.js ProcEnviron: TERM=xterm-256color PATH=(custom, no user) XDG_RUNTIME_DIR=<set> LANG=fr_FR.UTF-8 SHELL=/bin/bash Profiles: Profile0 (Default) - LastVersion=66.0.3/20190410124846 (In use) RunningIncompatibleAddons: False SourcePackage: firefox Themes: extensions.sqlite corrupt or missing UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 09/27/2017 dmi.bios.vendor: LENOVO dmi.bios.version: G7ETA9WW (2.69 ) dmi.board.asset.tag: Not Available dmi.board.name: 2353CTO dmi.board.vendor: LENOVO dmi.board.version: Not Defined dmi.chassis.asset.tag: No Asset Information dmi.chassis.type: 10 dmi.chassis.vendor: LENOVO dmi.chassis.version: Not Available dmi.modalias: dmi:bvnLENOVO:bvrG7ETA9WW(2.69):bd09/27/2017:svnLENOVO:pn2353CTO:pvrThinkPadT430s:rvnLENOVO:rn2353CTO:rvrNotDefined:cvnLENOVO:ct10:cvrNotAvailable: dmi.product.family: ThinkPad T430s dmi.product.name: 2353CTO dmi.product.sku: LENOVO_MT_2353 dmi.product.version: ThinkPad T430s dmi.sys.vendor: LENOVO To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1824409/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
