(In reply to fluks from comment #39) > In a bug related to this, someone was thinking about efficiency. Does it > matter if you add a button or a context menu item, then finding the path > needs to be done only for that one bookmark when the user requests it. SQLite > has had `WITH RECURSIVE` since 3.8.3, so you don't have to do recursion in > code anymore.
Yes, it is possible to add a contextual menu to Open Enclosing Folder using WITH RECURSIVE, though opening the target folder in the Library window may not be trivial (should be feasible anyway, one has to navigate the result and open containers accordingly to the path, then select the given bookmark). It would be nicer if we'd have a quick way of extracting path for each bookmark in a performant way, but it's not strictly necessary for this specific contextual menu option. I'd be ok extending PlacesUtils.bookmarks.fetch to also fetch the path of a bookmark if a specific option is passed into it (so, on demand). At this time we don't have the development resources to do it, so it's up to the community, if you want to contribute patches we can discuss a plan. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1672139 Title: Add "Open Enclosing Folder" context menu to search results of bookmarks in the Library window (link to view/open containing folder, parent folder button) Status in Mozilla Firefox: Confirmed Status in firefox package in Ubuntu: Confirmed Bug description: Firefox is great. It has bookmarks. But it is impossible to open bookmark's folder in search results. Steps to reproduce: 1. Open Firefox 2. Open its Bookmark Manager (<Ctrl+Shift+O>) 3. Search for bookmark 4. Try to find its folder with right-click menu. 5. It is impossible to find bookmark's folder. Expected results: Firefox is mature, so it is expected that user can find bookmark's folder. For example Google Chrome has "Show in folder" menu option. Note: original bug was reported 8 years ago, but it is not fixed. ProblemType: Bug DistroRelease: Ubuntu 12.04 Package: firefox 52.0+build2-0ubuntu0.12.04.1 ProcVersionSignature: Ubuntu 3.13.0-110.157~precise1-generic 3.13.11-ckt39 Uname: Linux 3.13.0-110-generic x86_64 AddonCompatCheckDisabled: False AlsaVersion: Advanced Linux Sound Architecture Driver Version k3.13.0-110-generic. ApportVersion: 2.0.1-0ubuntu17.15 Architecture: amd64 ArecordDevices: **** List of CAPTURE Hardware Devices **** card 0: PCH [HDA Intel PCH], device 0: ALC269VB Analog [ALC269VB Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 AudioDevicesInUse: USER PID ACCESS COMMAND /dev/snd/controlC0: nikolay 8420 F.... pulseaudio BuildID: 20170303013352 Card0.Amixer.info: Card hw:0 'PCH'/'HDA Intel PCH at 0xf7d18000 irq 46' Mixer name : 'Intel PantherPoint HDMI' Components : 'HDA:10ec0269,10431507,00100100 HDA:80862806,80860101,00100000' Controls : 24 Simple ctrls : 9 Channel: Unavailable Date: Sun Mar 12 13:59:45 2017 Extensions: extensions.sqlite corrupt or missing ForcedLayersAccel: False IfupdownConfig: auto lo iface lo inet loopback IncompatibleExtensions: Unavailable (corrupt or non-existant compatibility.ini or extensions.sqlite) InstallationMedia: Ubuntu 12.04.4 LTS "Precise Pangolin" - Release amd64 (20140204) IpRoute: default via 192.168.3.1 dev wlan3 proto static 169.254.0.0/16 dev wlan3 scope link metric 1000 192.168.3.0/24 dev wlan3 proto kernel scope link src 192.168.3.6 metric 2 192.168.122.0/24 dev virbr0 proto kernel scope link src 192.168.122.1 Locales: extensions.sqlite corrupt or missing MarkForUpload: True MostRecentCrashID: bp-a82bbe13-104c-487f-84dc-178712170311 Plugins: Shockwave Flash - /usr/lib/flashplugin-installer/libflashplayer.so PrefSources: prefs.js [Profile]/extensions/{3d7eb24f-2740-49df-8937-200b1cc08f8a}/defaults/preferences/flashblock.js [Profile]/extensions/[email protected]/defaults/preferences/prefs.js [Profile]/extensions/{e36db930-f18d-4449-b45f-e286cfb9e03a}/defaults/preferences/markingcollection-prefs.js [Profile]/extensions/[email protected]/defaults/preferences/tt_defaults.js Profiles: Profile0 (Default) - LastVersion=52.0/20170303013352 (In use) RunningIncompatibleAddons: False SourcePackage: firefox Themes: extensions.sqlite corrupt or missing UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 02/12/2014 dmi.bios.vendor: American Megatrends Inc. dmi.bios.version: UX32A.216 dmi.board.asset.tag: ATN12345678901234567 dmi.board.name: UX32A dmi.board.vendor: ASUSTeK COMPUTER INC. dmi.board.version: 1.0 dmi.chassis.asset.tag: No Asset Tag dmi.chassis.type: 10 dmi.chassis.vendor: ASUSTeK COMPUTER INC. dmi.chassis.version: 1.0 dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvrUX32A.216:bd02/12/2014:svnASUSTeKCOMPUTERINC.:pnUX32A:pvr1.0:rvnASUSTeKCOMPUTERINC.:rnUX32A:rvr1.0:cvnASUSTeKCOMPUTERINC.:ct10:cvr1.0: dmi.product.name: UX32A dmi.product.version: 1.0 dmi.sys.vendor: ASUSTeK COMPUTER INC. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1672139/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
