Created attachment 9104623 Bug 1590984 - Use poll() instead of select() in WebRTC code r=drno
The use of select() was leading to crashes when the file descriptor value was larger than FD_SETSIZE. Recent versions of glibc have checks in the FD_CLR(), FD_SET() and FD_ISSET() macros that will abort() the program instead of doing an out-of-bounds access. poll() doesn't have limitations on the file descriptor values and provides behavior that is otherwise identical to select() thus solving the problem. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1849615 Title: WebRTC-related crashes Status in Mozilla Firefox: Fix Released Status in firefox package in Ubuntu: New Bug description: In Mozilla we've detected a spike of crashes in the Ubuntu-packaged version of Firefox 69.0.x. All the crashes are happening in the WebRTC code and specifically libc's FD_SET, FD_CLR and FD_ISSET range- checking safety is causing an abort. Is it possible that Firefox is being built with a FD_SETSIZE value that's different from what's used in libc? To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1849615/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
