Comment on attachment 9104623 Bug 1590984 - Use poll() instead of select() in WebRTC code r=drno
### ESR Uplift Approval Request * **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: This fixes a crash that can easily occur when using WebRTC. * **User impact if declined**: Firefox may crash when using WebRTC; this will happen independently of the user since it's triggered by the file descriptor numbers used by the WebRTC devices (camera, microphone, etc...). * **Fix Landed on Version**: 72 * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: The fix is small and almost mechanical and the patch has been in nightly and then beta for two months now without causing regressions. * **String or UUID changes made by this patch**: None -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1849615 Title: WebRTC-related crashes Status in Mozilla Firefox: Fix Released Status in firefox package in Ubuntu: Fix Committed Bug description: In Mozilla we've detected a spike of crashes in the Ubuntu-packaged version of Firefox 69.0.x. All the crashes are happening in the WebRTC code and specifically libc's FD_SET, FD_CLR and FD_ISSET range- checking safety is causing an abort. Is it possible that Firefox is being built with a FD_SETSIZE value that's different from what's used in libc? To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1849615/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp