Comment on attachment 8754796 (2/2) - Stop using libgnome and libgnomeui on Linux v4
Review of attachment 8754796: ----------------------------------------------------------------- Looks good, thanks! There are a few style issues, but the file's style is highly inconsistent anyway. While I'm not that familiar with X11 session management, things seem quite sane according to https://www.x.org/releases/X11R7.6/doc/libSM/SMlib.html. ::: toolkit/xre/nsNativeAppSupportUnix.cpp @@ +429,5 @@ > + > + --gArgc; > +} > + > +static void setSMValue(SmPropValue& val, const nsCString& data) Please capitalize function names and add a newline after the return type declaration in implementations. Also, this block of code isn't guarded by MOZ_X11. Systems without X11 won't be able to resolve SmPropValue. @@ +436,5 @@ > + val.length = data.Length(); > +} > + > +static void setSMProperty(SmProp& prop, const char* name, const char* type, > + int numVals, SmPropValue vals[]) Style and guard as described above. @@ +491,5 @@ > + char *arg = *curarg; > + if (arg[0] == '-' && arg[1] == '-') { > + arg += 2; > + if (!strcmp(arg, "sm-disable")) { > + RemoveArg(curarg); Is there any reason we can't just increment argv / decrement argc here instead of shifting the char* pointers in RemoveArg? @@ +576,5 @@ > + char errbuf[256]; > + mSessionConnection = SmcOpenConnection(nullptr, this, SmProtoMajor, > + SmProtoMinor, mask, &callbacks, > + prev_client_id.get(), &client_id, > + 256, errbuf); Replace 256 with sizeof(errbuf). -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/867424 Title: Oneric: On boot up Firefox always displays the “Well, This Is Embarrassing” screen. Status in Mozilla Firefox: Fix Released Status in firefox package in Ubuntu: Triaged Status in thunderbird package in Ubuntu: Triaged Status in firefox source package in Precise: Triaged Status in thunderbird source package in Precise: Triaged Bug description: This happens on every restart or boot. Firefox fails to load previous tabs. ProblemType: Bug DistroRelease: Ubuntu 11.10 Package: firefox 7.0.1+build1+nobinonly-0ubuntu1 ProcVersionSignature: Ubuntu 3.0.0-12.19-generic 3.0.4 Uname: Linux 3.0.0-12-generic x86_64 NonfreeKernelModules: nvidia AddonCompatCheckDisabled: False AlsaVersion: Advanced Linux Sound Architecture Driver Version 1.0.24. AplayDevices: aplay: device_list:240: no soundcards found... ApportVersion: 1.23-0ubuntu2 Architecture: amd64 ArecordDevices: arecord: device_list:240: no soundcards found... AudioDevicesInUse: Error: command ['fuser', '-v', '/dev/snd/by-path', '/dev/snd/controlC0', '/dev/snd/hwC0D0', '/dev/snd/pcmC0D0c', '/dev/snd/pcmC0D0p', '/dev/snd/pcmC0D1p', '/dev/snd/pcmC0D2c', '/dev/snd/seq', '/dev/snd/timer'] failed with exit code 1: BuildID: 20110929022028 CRDA: Error: [Errno 2] No such file or directory Channel: release Date: Tue Oct 4 13:15:01 2011 ForcedLayersAccel: False IfupdownConfig: auto lo iface lo inet loopback IncompatibleExtensions: NoScript - ID={73a6fe31-595d-460b-a920-fcc0f8843232}, Version=2.1.4rc2, minVersion=1.9a2, maxVersion=1.9.6, Location=app-profile, Type=extension, Active=Yes InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Beta amd64 (20110910) IpRoute: default via 192.168.1.1 dev eth0 proto static 169.254.0.0/16 dev eth0 scope link metric 1000 192.168.1.0/24 dev eth0 proto kernel scope link src 192.168.1.4 metric 1 IwConfig: lo no wireless extensions. eth0 no wireless extensions. ProcEnviron: LANGUAGE=en_GB:en LANG=en_GB.UTF-8 SHELL=/bin/bash Profiles: Profile0 (Default) - LastVersion=7.0.1/20110929022028 (Running) RfKill: RunningIncompatibleAddons: True SourcePackage: firefox UpgradeStatus: No upgrade log present (probably fresh install) UserJS: general.useragent.vendor - Firefox dmi.bios.date: 01/23/2008 dmi.bios.vendor: American Megatrends Inc. dmi.bios.version: 0304 dmi.board.asset.tag: To Be Filled By O.E.M. dmi.board.name: M3A78-EH dmi.board.vendor: ASUSTeK Computer INC. dmi.board.version: Rev 1.xx dmi.chassis.asset.tag: Asset-1234567890 dmi.chassis.type: 3 dmi.chassis.vendor: Chassis Manufacture dmi.chassis.version: Chassis Version dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvr0304:bd01/23/2008:svnSystemmanufacturer:pnSystemProductName:pvrSystemVersion:rvnASUSTeKComputerINC.:rnM3A78-EH:rvrRev1.xx:cvnChassisManufacture:ct3:cvrChassisVersion: dmi.product.name: System Product Name dmi.product.version: System Version dmi.sys.vendor: System manufacturer To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/867424/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
