** Changed in: zsys (Ubuntu)
   Importance: Undecided => Low

** Changed in: zsys (Ubuntu)
     Assignee: (unassigned) => Didier Roche (didrocks)

** Also affects: zsys (Ubuntu Focal)
   Importance: Undecided
       Status: New

** Changed in: zsys (Ubuntu Focal)
   Importance: Undecided => Low

** Changed in: zsys (Ubuntu Focal)
     Assignee: (unassigned) => Didier Roche (didrocks)

** Description changed:

+ [Impact]
+  * ZSys user autosave feature was trying to save GDM users on systems that 
don’t have their GDM session teared down after logged in (nvidia binary driver).
+  * The saving was failing as no GDM dataset was created.This was only visible 
in logs:
+ mai 12 09:41:27 casanier zsysd[48398]: gdm
+ mai 12 09:41:27 casanier zsysctl[48826]: level=error msg="couldn't save state 
for user \"gdm\":user \"gdm\" doesn't exist"
+ mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Main 
process exited, code=exited, status=1/FAILURE
+ mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Failed 
with result 'exit-code'.
+ mai 12 09:41:27 casanier systemd[2480]: Failed to start Save current user 
state periodically.
+ 
+ 
+ [Test Case]
+  1. Install the new ZSys on a machine which gdm session doesn’t tear down
+  2. Wait for 5 minutes after boot so that the autosave user timer is 
triggered.
+  3. Check the logs: the timer isn’t ran for gdm user.
+ 
+ [Regression Potential]
+  * The fix is about adding ConditionUser=!@system to the systemd user 
autosave features, so that any user with UID < 1000 (which are the users we 
don’t create user datasets for) are not considered.
+  * The failure was silent for most of users who don’t look at the logs.
+ 
+ 
+ -----
+ 
  From the log:
  
  mai 12 09:41:27 casanier zsysd[48398]: gdm
  mai 12 09:41:27 casanier zsysctl[48826]: level=error msg="couldn't save state 
for user \"gdm\":user \"gdm\" doesn't exist"
  mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Main 
process exited, code=exited, status=1/FAILURE
  mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Failed 
with result 'exit-code'.
  mai 12 09:41:27 casanier systemd[2480]: Failed to start Save current user 
state periodically.
  mai 12 09:42:27 casanier systemd[1]: zsysd.service: Succeeded.
  
  We should avoid by default logging user ID < 1000 but root rather than
  outputting an error.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to zsys in Ubuntu.
https://bugs.launchpad.net/bugs/1881539

Title:
  zsys tries to save gdm user home which doesn’t exit

Status in zsys package in Ubuntu:
  Fix Released
Status in zsys source package in Focal:
  New

Bug description:
  [Impact]
   * ZSys user autosave feature was trying to save GDM users on systems that 
don’t have their GDM session teared down after logged in (nvidia binary driver).
   * The saving was failing as no GDM dataset was created.This was only visible 
in logs:
  mai 12 09:41:27 casanier zsysd[48398]: gdm
  mai 12 09:41:27 casanier zsysctl[48826]: level=error msg="couldn't save state 
for user \"gdm\":user \"gdm\" doesn't exist"
  mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Main 
process exited, code=exited, status=1/FAILURE
  mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Failed 
with result 'exit-code'.
  mai 12 09:41:27 casanier systemd[2480]: Failed to start Save current user 
state periodically.

  
  [Test Case]
   1. Install the new ZSys on a machine which gdm session doesn’t tear down
   2. Wait for 5 minutes after boot so that the autosave user timer is 
triggered.
   3. Check the logs: the timer isn’t ran for gdm user.

  [Regression Potential]
   * The fix is about adding ConditionUser=!@system to the systemd user 
autosave features, so that any user with UID < 1000 (which are the users we 
don’t create user datasets for) are not considered.
   * The failure was silent for most of users who don’t look at the logs.

  
  -----

  From the log:

  mai 12 09:41:27 casanier zsysd[48398]: gdm
  mai 12 09:41:27 casanier zsysctl[48826]: level=error msg="couldn't save state 
for user \"gdm\":user \"gdm\" doesn't exist"
  mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Main 
process exited, code=exited, status=1/FAILURE
  mai 12 09:41:27 casanier systemd[2480]: zsys-user-savestate.service: Failed 
with result 'exit-code'.
  mai 12 09:41:27 casanier systemd[2480]: Failed to start Save current user 
state periodically.
  mai 12 09:42:27 casanier systemd[1]: zsysd.service: Succeeded.

  We should avoid by default logging user ID < 1000 but root rather than
  outputting an error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zsys/+bug/1881539/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to