Disco and Eoan are EOL though, and Focal looks like it already has upstream commit 19e0840 included. So isn't it your proposed Bionic upload that would be different? Why not look into making that the same as what is in Focal?
Regardless, I'd like you to please at least consider the possibility that cherry-picking only 86a00b6 from upstream is an incomplete fix to this bug and look into further upstream changes to that file since that commit to see if 19e0840 or others are relevant. If after understanding the relevant changes you conclude that there is still a benefit to SRU this as-is, can explain the trade-off in not also taking the other relevant changes and can make the case for 19e0840 being correct on its own, then I'll consider that. As it stands it appears to me that 19e0840 contains an oversight that was since corrected upstream, but your SRU doesn't include the correction. Unless you change my mind, I don't consider this acceptable for SRU. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-shell in Ubuntu. https://bugs.launchpad.net/bugs/1838152 Title: gnome-shell freezes on notification arrival (fixed upstream) Status in GNOME Shell: Fix Released Status in gnome-shell package in Ubuntu: Fix Released Status in gnome-shell source package in Bionic: In Progress Status in gnome-shell source package in Disco: Fix Released Status in gnome-shell source package in Eoan: Fix Released Bug description: [ Description ] Sometimes certain notifications make the desktop unresponsive for a few seconds and then gnome-shell crashes and all extensions are reloaded. [ Test case ] Install gsconnect extension in gnome-shell: https://extensions.gnome.org/extension/1319/gsconnect/ - Start Up system - first Notification from connected device - Hangs for about 20 sec + This should not happen [ Regression potential ] Persistent state is not kept, although the patch is living upstream for many cycles already, so it's pretty safe. ----- I have found an upstream bug with a patch, but it's probably not in the Ubuntu's package. I thought of creating an issue in case it is something not known. https://gitlab.gnome.org/GNOME/gnome-shell/issues/470 https://gitlab.gnome.org/GNOME/gnome- shell/commit/86a00b6872375a266449beee1ea6d5e94f1ebbcb In my case it happens only with the notifications of gsconnect and maybe android studio. I have reproduced the problem in gsconnect in case it helps. https://github.com/andyholmes/gnome-shell-extension-gsconnect/issues/549 the error is: lug 27 19:55:56 ghv gnome-shell[4071]: Object Meta.Background (0x55ce6b4cf300), has been already deallocated - impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs Ubuntu 18.04 gnome-shell Version: 3.28.4-0ubuntu18.04.1 To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell/+bug/1838152/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
