For below error in test-stylus-validity and  test-dbverify, I add this
patch to support the 'Mobile' type.

Bail out! libwacom-FATAL-WARNING: Stylus '0x1' has no type defined,
falling back to 'General'

commit 36a22c884f3439fd72bfc2268afd1c29364ffee8
Author: Jason Gerecke <[email protected]>
Date:   Fri Nov 1 15:24:03 2019 -0700

    Introduce WSTYLUS_MOBILE type for AES devices
····
    AES styli are distinct enough from the existing stylus classes to
    deserve one of their own. This class is named WSTYLUS_MOBILE both to
    reflect the fact that AES sensors are only found on tablet PCs and to
    allow the potential inclusion of other similar sensors which may not
    use AES tech.
····
    Stylus test cases are added to cover the future addition of AES styli
    to libwacom.
····
    Signed-off-by: Jason Gerecke <[email protected]>


** Patch added: "introduce_WSTYLUS_MOBILE_type.patch"
   
https://bugs.launchpad.net/ubuntu/+source/libwacom/+bug/1921991/+attachment/5490643/+files/introduce_WSTYLUS_MOBILE_type.patch

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to libwacom in Ubuntu.
https://bugs.launchpad.net/bugs/1921991

Title:
  [SRU] Support isdv4-aes stylus group and multiple AES stylus
  definitions

Status in OEM Priority Project:
  Triaged
Status in libwacom package in Ubuntu:
  Fix Released
Status in libwacom source package in Focal:
  Fix Committed
Status in libwacom source package in Groovy:
  Incomplete

Bug description:
  [Impact]

   * There are lots of stylus couldn't be used on Lenovo's platform, our
  OEM customer request to support ThinkPad P15 Gen 1, ThinkPad X1 Yoga
  Gen5, ThinkPad P1 G3.

   * I reviewed and tested the below patches from upstream. It could
  support the stylus very well on P15, P1 or X1 Yoga.

   * a864679 - Add multiple AES stylus definitions 
     I applied into libwacom2 1.3-2ubuntu1, no errors.

   * 8652aa3 - Add isdv4-aes stylus group to all AES sensors
    I tried to apply this patch, but there are not 'data/isdv4-48ca.tablet' and 
'data/isdv4-48ce.tablet', it failed for these two files.

   * ba02abf - Add ISDv4 51e9 (Lenovo ThinkPad P15 Gen 1) (#325)

  [Test Plan]

   * Need your laptop have AES stylus, check the pen setting at gnome-
  control-center when the pen touch the screen. It could not
  set/customize the stylus, such as the second button as right click.

   * After updated the new packages with these patches, you could
  customize the stylus at gnome-control-center.

  [Where problems could occur]

   * It only changes the data/ parts to support more stylus from
  upstream, so it's low risk.

  [Other Info]

   * Related bug:
  https://bugs.launchpad.net/ubuntu/+source/libwacom/+bug/1869059

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/1921991/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to