Hello Seth, or anyone else affected, Accepted adsys into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/adsys/0.9.2~20.04 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: adsys (Ubuntu Focal) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to adsys in Ubuntu. https://bugs.launchpad.net/bugs/1961458 Title: chown of script directory and contents Status in adsys package in Ubuntu: Fix Released Status in adsys source package in Focal: Fix Committed Bug description: [Impact] Potential security issues in ApplyPolicy due to race when scripts are enabled. [Test Plan] 1. Attach your machine to Ubuntu Advantage to get script support. 2. Add a script to one GPO for user login/logout 3. Login as an user, starting a new user session (no session should be currently running for that given user). 4. Check the permissions are following what is described from the discussion below. [Where problems could occur] Script support was added recently, and it needs Ubuntu Advantage enablement to be activated. However, to this day, there is still no official ubuntu-advantage-desktop-daemon packaged on focal. ---- ./internal/policies/scripts/scripts.go ApplyPolicy() unsafe owner changes: Changing the scripts directory owner allows any user processes to create symbolic links within, and then they can take ownership of any file on writable mounts. If the files must be owned by the user, the best way is to switch to the user's uid before creating the files. fchown(2) of the file descriptor before closing it should also work. I lose track of what's happening around the "Running machine startup scripts" -- it looks to me like adsys is also *executing* the scripts that were moments ago given to the user to modify. It is not safe for root to run user-owned files. Does the user *have* to own the directory and scripts? Thanks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1961458/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
