My proposed fix to Chromium start-up script wasn't foolproof. One can
naturally also export CHROMIUM_FLAGS instead of defining it in
~/chromium.init.

Passing arguments via a variable is a bad idea if one wants both to be
reliable with odd input (i.e. accept arguments with spaces (as in the
bug report), newlines etc.) and also to be portable, accepting the
variable as environment or by sourcing it from a script such as
~/chromium.init.

It's no coincidence that all programs — correct me if I'm wrong — that
do allow that kind of thing either don't offer arguments with spaces
(less) or allow only one argument per variable (quilt, git, reportbug).

So I'm reverting it and changing the script to detect if CHROMIUM_FLAGS
is being used and has any space, then warn on stderr that it will fail
for arguments that contain space.

** Changed in: chromium-browser (Ubuntu)
       Status: Fix Released => Won't Fix

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/1514484

Title:
  Chromium start-up script doesn't accept argument values with spaces in
  $CHROMIUM_FLAGS, cause is lack of quotes

Status in chromium-browser package in Ubuntu:
  Won't Fix

Bug description:
  You can't have arguments with spaces inside CHROMIUM_FLAGS, whatever
  comes after the first space is going to be interpreted as an URL by
  the actual chromium binary. Easy repro:

  1. Set user's CHROMIUM_FLAGS with an argument containing spaces, eg:
  $ echo 'CHROMIUM_FLAGS=--user-agent="A B C"' > .chromium-browser.init

  2. Run chromium:
  $ /usr/bin/chromium-browser

  3. See 2 extra open tabs, one trying to open URL 'B', the other 'C'.

  The cause for this funny behavior is the lack of quotes around
  $CHROMIUM_FLAGS in the script installed in /usr/bin/chromium-browser
  -- it calls $LIBDIR/$APPNAME $CHROMIUM_FLAGS "$@" by the end of the
  script. I've tried working around it but couldn't, no amount of
  escaping and extra quotes seems to help if it's called like that.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1514484/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to