I think this should probably fix the duplicated temporary connections
issue. Netplan should only ever try to handle non-temporary connections,
nothing that's being written to NMS_KEYFILE_STORAGE_TYPE_RUN (like those
external OpenVPN connections). More testing is needed to investigate the
side-effects of this change.
```
diff --git a/src/core/settings/plugins/keyfile/nms-keyfile-writer.c
b/src/core/settings/plugins/keyfile/nms-keyfile-writer.c
index b893717c20..65e4e857ec 100644
--- a/src/core/settings/plugins/keyfile/nms-keyfile-writer.c
+++ b/src/core/settings/plugins/keyfile/nms-keyfile-writer.c
@@ -418,7 +418,8 @@ _internal_write_connection(NMConnection
*connection,
unlink(existing_path);
/* NETPLAN: write only non-temporary files to /etc/netplan/... */
- if (!is_volatile && !is_nm_generated && !is_external) {
+ if (!is_volatile && !is_nm_generated && !is_external &&
+ strstr(keyfile_dir, "/etc/NetworkManager/system-connections")) {
g_autofree gchar *ssid = g_key_file_get_string(kf_file, "wifi",
"ssid", NULL);
g_autofree gchar *escaped_ssid = ssid ?
g_uri_escape_string(ssid, NULL, TRUE)
: NULL;
```
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to network-manager in Ubuntu.
https://bugs.launchpad.net/bugs/1998207
Title:
netplan network-manager plugin tries to save temporary connections
Status in netplan:
Triaged
Status in network-manager package in Ubuntu:
Triaged
Bug description:
*** Note: This bug is mostly about comment #10, now ***
When creating an OpenVPN connection, a temporal connection called tunN
is created. For instance, after activating a connection called
vpntest, I have:
NAME UUID TYPE DEVICE
vpntest 458856e6-8f0f-4dc6-82f2-dd72868252a0 vpn ens3
tun0 1eb1dbe8-5678-4818-9adf-fb2dc01ed132 tun tun0
tun0 is created/removed after activating/deactivating vpntest and
should not really be saved, but I see netplan adding it in
/etc/netplan. And while doing so the plugin also reports some errors
(I see these when stopping the connection):
Nov 28 16:16:57 ubuntu NetworkManager[11752]: <error> [1669652217.2920] BUG:
the profile cannot be stored in keyfile format without becoming unusable:
cannot access file: No such file or directory
Nov 28 16:16:57 ubuntu NetworkManager[11752]:
((src/libnm-core-impl/nm-connection.c:342)): assertion '<dropped>' failed
Nov 28 16:16:57 ubuntu NetworkManager[11752]: <warn> [1669652217.2920]
keyfile: commit: failure to write 1eb1dbe8-5678-4818-9adf-fb2dc01ed132 ((null))
to
"/run/NetworkManager/system-connections/tun0-1eb1dbe8-5678-4818-9adf-fb2dc01ed132.nmconnection":
keyfile writer produces an invalid connection: cannot access file: No such
file or directory
To manage notifications about this bug go to:
https://bugs.launchpad.net/netplan/+bug/1998207/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
