This bug was fixed in the package ubuntu-drivers-common - 1:0.9.6.3.2
---------------
ubuntu-drivers-common (1:0.9.6.3.2) kinetic; urgency=medium
* UbuntuDrivers/detect.py:
- Fix "882:5 local variable 'with_nvidia_kms' is assigned to
but never used" FTBFS (triggered by tests/test_static.py).
ubuntu-drivers-common (1:0.9.6.3.1) kinetic; urgency=medium
[ Alberto Milone ]
* debian/rules:
- Limit the tests to the selected architectures (amd64, arm64).
This prevents armhf builds from failing.
* UbuntuDrivers/detect.py:
- Make sure all -open drivers have a lower priority, regardless
of whether the --server parameter is passed in or not.
- Update regex and unify package name parsing in the following
functions by using the new NvidiaPkgNameInfo class:
nvidia_desktop_pre_installation_hook,
_get_headless_no_dkms_metapackage,
nvidia_desktop_pre_installation_hook,
get_linux_modules_metapackage.
This prevents ubuntu-drivers from crashing when dealing with
the -open NVIDIA drivers (LP: #1993019).
* tests/test_ubuntu_drivers.py:
- Add tests so we make sure to keep preferring non-open NVIDIA
modules over the -open ones, at least until the open modules catch up
feature wise and performance wise.
[ gongzhengyang ]
* UbuntuDrivers/detect.py:
- Fix local variable 'version' being referenced before assignment
when catching ValueError (LP: #1993019).
[ Jeff Lane ]
* detect-plugins/sl-modem.py:
- Add some error trapping when aplay is not installed (on servers)
(LP: #1935070).
-- Alberto Milone <[email protected]> Wed, 08 Mar 2023
15:57:25 +0000
** Changed in: ubuntu-drivers-common (Ubuntu Kinetic)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to ubuntu-drivers-common in Ubuntu.
https://bugs.launchpad.net/bugs/1993019
Title:
UnboundLocalError: local variable 'version' referenced before
assignment
Status in ubuntu-drivers-common package in Ubuntu:
Fix Released
Status in ubuntu-drivers-common source package in Bionic:
Triaged
Status in ubuntu-drivers-common source package in Focal:
Triaged
Status in ubuntu-drivers-common source package in Jammy:
Fix Committed
Status in ubuntu-drivers-common source package in Kinetic:
Fix Released
Bug description:
[ Impact ]
* The introduction of the -open NVIDIA drivers requires a change in
the way we detect driver series and flavours. Failing to do so, causes
the ubuntu-drivers tool to crash (LP: #1993019), or to prefer the
-open drivers over the non-open ones (LP: #1988836).
* Furthermore, calling the ubuntu-drivers tool where the alsa-utils
package is not installed (mainly on servers), ubuntu-drivers (through
the sl-modem plugin) complains, unnecessarily about the missing aplay
binary.
[ Test Plan ]
* Install the new ubuntu-drivers-common from -proposed on a system
where the GPU is compatible with the 515 series (or higher).
* Run the ubuntu-drivers list command, and make sure that the 515
driver series (or higher) is listed.
* Try installing the driver using the following command:
sudo ubuntu-drivers install
* Check which driver series was installed (you can use the "sudo
ubuntu-drivers debug" command), and make sure that the installation
does not cause ubuntu-drivers to crash.
[ Where problems could occur ]
* A problem in the ubuntu-drivers tool can cause it to install a driver which
is not recommended for the detected hardware, or even cause the package
installation to fail, and prevent users from logging in through the
graphics interface.
[ Other Info ]
* To prevent failures of the test-suite on architectures such as armhf (as
seen
in Lunar), we are skipping the tests for any architectures other than amd64
and arm64 (which are the only ones actually using ubuntu-drivers).
This was already the case with riscv, and we now have an easier way
to do so in the debian/rules file.
== Changelogs ==
=== Kinetic and Jammy ===
[ Alberto Milone ]
* New upstream release:
* UbuntuDrivers/detect.py:
- Make sure all -open drivers have a lower priority, regardless
of whether the --server parameter is passed in or not.
- Update regex in nvidia_desktop_pre_installation_hook. This prevents
ubuntu-drivers from crashing when dealing with the -open NVIDIA
drivers (LP: #1993019).
* tests/test_ubuntu_drivers.py:
- Add tests so we make sure to keep preferring non-open NVIDIA
modules over the -open ones, at least until the open modules catch up
feature wise and performance wise.
[ gongzhengyang ]
* UbuntuDrivers/detect.py:
- Fix local variable 'version' being referenced before assignment
when catching ValueError (LP: #1993019).
[ Jeff Lane ]
* detect-plugins/sl-modem.py:
- Add some error trapping when aplay is not installed (on servers).
=== Jammy only (left over from 1:0.9.6.2~0.22.04.1) ===
* UbuntuDrivers/detect.py:
- Make sure -open drivers have a lower priority (LP: #1988836).
== Changelogs ==
=== Kinetic and Jammy ===
[ Alberto Milone ]
* debian/rules:
- Limit the tests to the selected architectures (amd64, arm64).
This prevents armhf builds from failing.
* UbuntuDrivers/detect.py:
- Make sure all -open drivers have a lower priority, regardless
of whether the --server parameter is passed in or not.
- Update regex and unify package name parsing in the following
functions by using the new NvidiaPkgNameInfo class:
nvidia_desktop_pre_installation_hook,
_get_headless_no_dkms_metapackage,
nvidia_desktop_pre_installation_hook,
get_linux_modules_metapackage,
This prevents ubuntu-drivers from crashing when dealing with
the -open NVIDIA drivers (LP: #1993019).
* tests/test_ubuntu_drivers.py:
- Add tests so we make sure to keep preferring non-open NVIDIA
modules over the -open ones, at least until the open modules catch up
feature wise and performance wise.
[ gongzhengyang ]
* UbuntuDrivers/detect.py:
- Fix local variable 'version' being referenced before assignment
when catching ValueError (LP: #1993019).
[ Jeff Lane ]
* detect-plugins/sl-modem.py:
- Add some error trapping when aplay is not installed (on servers).
=== Jammy only (left over from 1:0.9.6.2~0.22.04.1) ===
* UbuntuDrivers/detect.py:
- Make sure -open drivers have a lower priority (LP: #1988836).
____
Hello, we received a drive-by complaint about the ubuntu-drivers autoinstall
tool:
< Fhazal> hye i have problem with ubuntu 22.04 nvidia auto install command
< Fhazal> this error appear when i try to auto install recommended driver
< Fhazal> https://pastebin.com/ydZVFT24
The contents of the pastebin:
Traceback (most recent call last):
File "/usr/bin/ubuntu-drivers", line 513, in <module>
greet()
File "/usr/lib/python3/dist-packages/click/core.py", line 1128, in __call__
return self.main(*args, **kwargs)
File "/usr/lib/python3/dist-packages/click/core.py", line 1053, in main
rv = self.invoke(ctx)
File "/usr/lib/python3/dist-packages/click/core.py", line 1659, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python3/dist-packages/click/core.py", line 1395, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python3/dist-packages/click/core.py", line 754, in invoke
return __callback(*args, **kwargs)
File "/usr/lib/python3/dist-packages/click/decorators.py", line 84, in
new_func
return ctx.invoke(f, obj, *args, **kwargs)
File "/usr/lib/python3/dist-packages/click/core.py", line 754, in invoke
return __callback(*args, **kwargs)
File "/usr/bin/ubuntu-drivers", line 432, in autoinstall
command_install(config)
File "/usr/bin/ubuntu-drivers", line 187, in command_install
UbuntuDrivers.detect.nvidia_desktop_pre_installation_hook(to_install)
File "/usr/lib/python3/dist-packages/UbuntuDrivers/detect.py", line 839, in
nvidia_desktop_pre_installation_hook
with_nvidia_kms = version >= 470
UnboundLocalError: local variable 'version' referenced before assignment
Skimming the version on my system it sure feels plausible:
def nvidia_desktop_pre_installation_hook(to_install):
'''Applies changes that need to happen before installing the NVIDIA
drivers'''
with_nvidia_kms = False
# Enable KMS if nvidia >= 470
for package_name in to_install:
if package_name.startswith('nvidia-driver-'):
try:
version = int(package_name.split('-')[-1])
except ValueError:
pass
finally:
with_nvidia_kms = version >= 470
if with_nvidia_kms:
set_nvidia_kms(1)
If there was an exception splitting, indexing, or converting to an
int, that 'version' variable may not have a value.
Thanks
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1993019/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
