On Tue, Oct 24, 2023 at 04:04:25PM -0000, Jeremy Bícha wrote: > I do not believe we have a desktop policy to help us determine when it > is better to either restart services or notify that a computer restart > is recommended.
As a user I would prefer to not have my vpn connection drop during a network-manager upgrade; or, barring that, to have it re-established after the service is restarted. And since that's not currently implemented, as a user it would be less annoying for me if the service was not restarted. HOWEVER, the default policy is to always restart services on upgrade, and this policy exists for a reason. Indeed, Lukas tells me we specifically need to restart NM on upgrade from lunar to mantic because without a restart, we can't do the connection migration - so in the most immediately interesting case a restart is mandatory anyway. The only system service we make an exception for is dbus because the whole system loses its mind if dbus goes away. So I think, given the set of knobs we currently have available for tweaking, the right answer is to drop the reboot-required bit. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to network-manager in Ubuntu. https://bugs.launchpad.net/bugs/2040292 Title: network-manager SRU flags system for restart required but also restarted the service Status in network-manager package in Ubuntu: Confirmed Bug description: After applying the network-manager SRU in mantic, I get a notification that a system restart is required to fully apply updates. This immediately raised a question, because I KNOW my network connection was restarted when the SRU was installed (I have a VPN that did not auto-reconnect). And I checked the state of the process - it was definitely restarted and is running from the binary currently on disk. The network-manager postinst has the following code: # request a reboot (NM tears down interfaces on restart # which is not the way we want to go) [ -x /usr/share/update-notifier/notify-reboot-required ] && \ /usr/share/update-notifier/notify-reboot-required But the service restart is also happening. debian/rules currently has: override_dh_installsystemd: dh_installsystemd -pnetwork-manager --no-start NetworkManager-dispatcher.service NetworkManager-wait-online.service nm-priv-helper.service dh_installsystemd -pnetwork-manager --no-also NetworkManager.service No other systemd overrides. Nothing inhibits the restart of the service. It needs to be one or the other. And if we're doing SRUs of network- manager, then this is bad UX for users applying their daily updates and should be fixed in SRU. ProblemType: Bug DistroRelease: Ubuntu 23.10 Package: network-manager 1.44.2-1ubuntu1.1 ProcVersionSignature: Ubuntu 6.5.0-9.9-generic 6.5.3 Uname: Linux 6.5.0-9-generic x86_64 NonfreeKernelModules: zfs ApportVersion: 2.27.0-0ubuntu5 Architecture: amd64 CasperMD5CheckResult: unknown CurrentDesktop: ubuntu:GNOME Date: Tue Oct 24 08:19:38 2023 InstallationDate: Installed on 2019-12-23 (1401 days ago) InstallationMedia: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191017) RebootRequiredPkgs: Error: path contained symlinks. SourcePackage: network-manager UpgradeStatus: Upgraded to mantic on 2023-10-16 (8 days ago) nmcli-nm: RUNNING VERSION STATE STARTUP CONNECTIVITY NETWORKING WIFI-HW WIFI WWAN-HW WWAN running 1.44.2 connected started full enabled enabled enabled missing enabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/2040292/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp