Thanks for the patch. In GNOME the preferred way to do this is with: https://docs.gtk.org/glib/func.return_val_if_fail.html
Actually that's exactly what the official version of gtk_widget_get_first_child in GTK4 does. Please then propose the fix at: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests to the gnome-42 branch (sorry I can't check it right now because the server is down). Or alternatively if the GNOME developers tell you 42 is too old for them to support then please propose the fix at: https://salsa.debian.org/gnome-team/nautilus/-/merge_requests to the ubuntu/jammy branch. Finally, in order to get the fix released to 22.04, the bug description needs to be updated: https://canonical-sru-docs.readthedocs- hosted.com/en/latest/reference/bug-template/ ** Changed in: nautilus (Ubuntu Jammy) Assignee: (unassigned) => Eugene Romanenko (eros2) ** Changed in: nautilus (Ubuntu Jammy) Status: Confirmed => In Progress ** Changed in: nautilus (Ubuntu Jammy) Milestone: None => jammy-updates -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/2011350 Title: ERROR:../src/nautilus-gtk4-helpers.c:116:gtk_widget_get_first_child: assertion failed: (GTK_IS_CONTAINER (widget)) Status in nautilus package in Ubuntu: Fix Released Status in nautilus source package in Jammy: In Progress Bug description: https://errors.ubuntu.com/problem/d6e8be4f90a24d66fd0bf410ccb31d3c6fd0eb9b --- Title: nautilus crashed with SIGABRT in g_assertion_message_expr() Sometimes Nautilus crashes when closing a window instead of exiting cleanly. It wouldn't be so bad if it didn't bring other windows down too. It usually happens when the window has multiple tabs. I tried to attach the crash log but it looks like apport only attached generic system info. I may have used the wrong apport command so I attached the .crash file manually. I'm not sure if it has all the necessary symbols tho. Description: Ubuntu 22.04.2 LTS Release: 22.04 Nautilus 1:42.2-0ubuntu2.1 --- ProblemType: Bug ApportVersion: 2.20.11-0ubuntu82.3 Architecture: amd64 CasperMD5CheckResult: unknown CurrentDesktop: ubuntu:GNOME DistroRelease: Ubuntu 22.04 InstallationDate: Installed on 2020-06-05 (1010 days ago) InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423) NonfreeKernelModules: nvidia_modeset nvidia Package: nautilus 1:42.2-0ubuntu2.1 PackageArchitecture: amd64 ProcVersionSignature: Ubuntu 5.19.0-35.36~22.04.1-generic 5.19.17 Tags: jammy Uname: Linux 5.19.0-35-generic x86_64 UpgradeStatus: Upgraded to jammy on 2022-10-06 (157 days ago) UserGroups: adm cdrom dip kvm lpadmin lxd plugdev sambashare sudo _MarkForUpload: True usr_lib_nautilus: evince 42.3-0ubuntu3 file-roller 3.42.0-1 nautilus-extension-gnome-terminal 3.44.0-1ubuntu1 nautilus-share 0.7.3-2ubuntu6 --- ProblemType: Bug ApportVersion: 2.20.11-0ubuntu82.3 Architecture: amd64 CasperMD5CheckResult: unknown CurrentDesktop: ubuntu:GNOME DistroRelease: Ubuntu 22.04 InstallationDate: Installed on 2020-06-05 (1010 days ago) InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423) NonfreeKernelModules: nvidia_modeset nvidia Package: nautilus 1:42.2-0ubuntu2.1 PackageArchitecture: amd64 ProcVersionSignature: Ubuntu 5.19.0-35.36~22.04.1-generic 5.19.17 Tags: jammy Uname: Linux 5.19.0-35-generic x86_64 UpgradeStatus: Upgraded to jammy on 2022-10-06 (157 days ago) UserGroups: adm cdrom dip kvm lpadmin lxd plugdev sambashare sudo _MarkForUpload: True usr_lib_nautilus: evince 42.3-0ubuntu3 file-roller 3.42.0-1 nautilus-extension-gnome-terminal 3.44.0-1ubuntu1 nautilus-share 0.7.3-2ubuntu6 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/2011350/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
