This is a fly by night review.
I don't think it should be "lockPref" like autoconfig. With autoconfig,
it's a function call.
With the default pref files, you're specifying a preference.
so:
locked_pref("foo", "bar")
makes more sense it that context (the same as user_pref)
Looking through the code, it looks like you've assumed that if a pref is
locked, it becomes a default as well, is that correct?
The code looks good to me, but I'm not the right person to do this.
I think this is a good solution to the problem you are seeing and makes
it a lot easier for enterprises to lock prefs, so this would be a good
thing to have.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/541951
Title:
Firefox 3.6 does not honour lockPref
Status in The Mozilla Firefox Browser:
In Progress
Status in “firefox” package in Ubuntu:
Fix Released
Bug description:
Binary package hint: firefox
In firefox 3.5 the following worked:
Set
lockPref("network.proxy.type", 5);
in /etc/firefox-3.5/pref/firefox.js
Setting lockPref in /etc/firefox/pref/firefox.js in firefox 3.6 does
not lock down the proxy.
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/541951/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
