This is a fly by night review.
I don't think it should be "lockPref" like autoconfig. With autoconfig,
it's a function call.
With the default pref files, you're specifying a preference.
so:
locked_pref("foo", "bar")
makes more sense it that context (the same as user_pref)
Looking through the code, it looks like you've assumed that if a pref is
locked, it becomes a default as well, is that correct?
The code looks good to me, but I'm not the right person to do this.
I think this is a good solution to the problem you are seeing and makes
it a lot easier for enterprises to lock prefs, so this would be a good
thing to have.
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/623844
Title:
lockpref not honored in /etc/thunderbird/pref/thunderbird.js
Status in Mozilla Thunderbird Mail and News:
In Progress
Status in “thunderbird” package in Ubuntu:
New
Bug description:
Binary package hint: thunderbird
appended /etc/thunderbird/pref/thunderbird.js with the following line:
lockpref("app.update.enabled", false);
When starting Thunderbird and checking the config app.update.enabled
is set to false, but can be edited by the user.
ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: thunderbird 3.0.6+build2+nobinonly-0ubuntu0.10.04.1
ProcVersionSignature: Ubuntu 2.6.32-24.39-generic 2.6.32.15+drm33.5
Uname: Linux 2.6.32-24-generic x86_64
Architecture: amd64
Date: Wed Aug 25 09:58:43 2010
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
ProcEnviron:
PATH=(custom, no user)
LANG=de_DE.utf8
SHELL=/bin/bash
SourcePackage: thunderbird
To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/623844/+subscriptions
--
Mailing list: https://launchpad.net/~desktop-packages
Post to : [email protected]
Unsubscribe : https://launchpad.net/~desktop-packages
More help : https://help.launchpad.net/ListHelp
