(In reply to comment #12) > From outside, copying the implementation from LO-Draw to LO-Writer doesn't > seem > to be much work. I haven't looked into the code yet. Is there someone who can > really estimate, how much effort it will be to port this from LO-Draw to > LO-Writer? Is it worth to create a build environment etc.?
I looked a bit into the code: First of all, a crop button can be added to writer by editing (draw) http://cgit.freedesktop.org/libreoffice/core/tree/sw/uiconfig/swriter/toolbar/graphicobjectbar.xml similar to (writer) http://cgit.freedesktop.org/libreoffice/core/tree/sw/uiconfig/swriter/toolbar/graphicobjectbar.xml The button is then always deactivated and further editing is needed. The files (draw) http://cgit.freedesktop.org/libreoffice/core/tree/svx/source/tbxctrls/grafctrl.cxx and (writer) http://cgit.freedesktop.org/libreoffice/core/tree/sw/source/ui/shells/grfsh.cxx are quite similar. There are blocks labeled "SID_ATTR_GRAF_CROP" in SvxGrafAttrHelper::ExecuteGrafAttr() and SvxGrafAttrHelper::GetGrafAttrState() in the first file. The corresponding functions SwGrfShell::ExecAttr() and SwGrfShell::GetAttrState() in the second file have quite similar structure but have different number of parameters. If I just copy the Crop-blocks from draw to writer there are a lot of errors of course. Is there somebody who knows how to translate the draw-part into the writer-part? Is translating draw into writer the correct approach or shouldn't writer and draw use about the same functions when handling graphics? Is there some further work to do that I missed? -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libreoffice in Ubuntu. https://bugs.launchpad.net/bugs/491746 Title: [Upstream] No interactive crop in Writer Status in LibreOffice Productivity Suite: Confirmed Status in The OpenOffice.org Suite: Confirmed Status in “libreoffice” package in Ubuntu: Won't Fix Status in “openoffice.org” package in Ubuntu: Won't Fix Bug description: Binary package hint: openoffice.org OpenOffice.org Writer in both Karmic and Lucid appears to lack the interactive crop feature. This feature is present in Draw, and in Windows Writer builds. WORKAROUND: Secondary click picture -> click Picture... -> tab Crop. ProblemType: Bug Architecture: i386 Date: Thu Dec 3 18:08:10 2009 DistroRelease: Ubuntu 10.04 Package: openoffice.org-writer 1:3.1.1-5ubuntu1 ProcEnviron: PATH=(custom, user) LANG=en_AU.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.32-5.6-generic SourcePackage: openoffice.org Uname: Linux 2.6.32-5-generic i686 To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/491746/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
