(In reply to Landry Breuil from comment #89) > I've looked at try logs, and yes ENABLE_ASSEMBLER=1 is not set on the > commandline when building under shell/ with the patch.
Ah, OK. I looked at it in my Linux VM, and I really thought I saw ENABLE_ASSEMBLER in the command line for js.o, but given that that makes no sense, it makes sense that you found it's the opposite. :-) (In reply to Mike Hommey [:glandium] from comment #90) > Yes. That these things are in Makefile.in is a mistake anyways. JSC sets those flags in what we imported as assembler/wtf/Platform.h, which seems reasonable. In fact, I see they set ENABLE_ASSEMBLER in there depending on various conditions, which is maybe why the patch works on most platforms already. js-config.h also seems like a reasonable place, although since there is already ENABLE_ASSEMBLER and ENABLE_JIT stuff in Platform.h, maybe it will be easier to keep consistent if we do it there. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to thunderbird in Ubuntu. https://bugs.launchpad.net/bugs/908508 Title: Firefox/Thunderbird 10 FTBFS on powerpc in js/src/yarr/pcre Status in The Mozilla Firefox Browser: In Progress Status in “firefox” package in Ubuntu: Fix Released Status in “thunderbird” package in Ubuntu: Fix Released Bug description: Debian has the fix, so I'll add it to the branch and it should work with the next upload. To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/908508/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : [email protected] Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
