Pretty good activity on Cold Case PR clean-up. We've clean up about 30, but will have at least 50 cold case PRs to resolve.
All the empty, red, or brown items need to be resolved however. @artwr (arthur), @mistercrunch (max), @zodian, and @jlowin, can you aim to resolve your target PRs this week? Also, if others have time, please pitch in. -s[image: Inline image 1] On Mon, Oct 17, 2016 at 10:33 AM, siddharth anand <[email protected]> wrote: > Arthur's picked up 12 (Yaay)! Please work with him to resolve your PRs. > > Steven, Dan (Aoen), Chris, Bolke, Patrick? Any chance you can take on a > few? > > > [image: Inline image 1] > > On Sun, Oct 16, 2016 at 2:53 PM, siddharth anand <[email protected]> > wrote: > >> I've closed around 13... less than half of which were merged - the >> remainder were closed after 4-5 days of not hearing from submitters. If >> resubmitted, I'd be happy to take a look. >> >> https://cwiki.apache.org/confluence/display/AIRFLOW/Cold- >> Case+PR+Resolution >> >> I noticed the msumit & mistercrunch reached out to submitters for their >> cold-case PRs. Please work with them. For any PRs closed without merging, >> please update the JIRA to be unassigned and to no longer point to the dead >> PR. Please review the link above. >> >> JIRAs with "squatters" is an anti-pattern that I have also been guilty >> of. It's best to take on JIRAs that we have a reasonable chance of >> delivering in a few weeks. >> >> >> -s >> >> On Wed, Oct 12, 2016 at 1:09 PM, Ben Tallman <[email protected]> wrote: >> >>> Sid - >>> >>> Thanks for staying on top of this. One of the most important things when >>> we >>> looked at Airflow vs Others was the health of the community (OK, a lack >>> of >>> valid competition was also important). >>> >>> When the community makes an effort to contribute, it requires PRs to be >>> moderated and handled. To that end, staying on top of PRs is a huge >>> commitment, as well as a sign of health. >>> >>> Ben >>> >>> >>> Thanks, >>> Ben >>> >>> *--* >>> *ben tallman* | *apigee >>> <http://t.sidekickopen06.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x >>> 6l2B9nMJW7t5XZs4WJfgqW4WJj7n3MP7VWW3LqXLC56dWRRf2H8CkP02?t=h >>> ttp%3A%2F%2Fwww.apigee.com%2F&si=5141814536306688&pi=2665104 >>> 7-656d-4e35-b344-b55a7b0d51ef>* >>> | m: +1.503.680.5709 | o: +1.503.608.7552 | twitter @anonymousmanage >>> <http://t.sidekickopen06.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x >>> 6l2B9nMJW7t5XZs4WJfgqW4WJj7n3MP7VWW3LqXLC56dWRRf2H8CkP02?t=h >>> ttp%3A%2F%2Ftwitter.com%2Fanonymousmanage&si=514181453630668 >>> 8&pi=26651047-656d-4e35-b344-b55a7b0d51ef> >>> @apigee >>> <http://t.sidekickopen06.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x >>> 6l2B9nMJW7t5XZs4WJfgqW4WJj7n3MP7VWW3LqXLC56dWRRf2H8CkP02?t=h >>> ttps%3A%2F%2Ftwitter.com%2Fapigee&si=5141814536306688&pi= >>> 26651047-656d-4e35-b344-b55a7b0d51ef> >>> <http://t.sidekickopen06.com/e1t/c/5/f18dQhb0S7lC8dDMPbW2n0x >>> 6l2B9nMJW7t5XZs4WJfgqW4WJj7n3MP7VWW3LqXLC56dWRRf2H8CkP02?t=h >>> ttp%3A%2F%2Fadapt.apigee.com%2F&si=5141814536306688&pi=26651 >>> 047-656d-4e35-b344-b55a7b0d51ef> >>> >>> On Wed, Oct 12, 2016 at 12:38 PM, siddharth anand <[email protected]> >>> wrote: >>> >>> > Max, >>> > Thanks for adding to the list. >>> > https://cwiki.apache.org/confluence/display/AIRFLOW/ >>> > Cold-Case+PR+Resolution >>> > >>> > >>> > If you're a committer on Airflow, please read closely. >>> > >>> > I would like us to commit to reviewing PRs within 2 weeks. 90% of our >>> PRs >>> > were older than that as per an earlier email. That's resulting in an >>> bad >>> > experience for our community and contributors. Before we can make that >>> > commitment, we need to clean up what are mostly abandoned PRs. >>> > >>> > Please do the following at your earliest: >>> > >>> > - Pick 10 PRs opened before Oct 2 >>> > - Review it. If the PR is ready to merge, please test and merge it >>> > - In most cases, the PRs require some action from the submitters >>> > - Comment on the PR asking the submitter to update the PR >>> > - If the submitter does not respond within a week, you can close >>> the >>> > PR with comments such as "PR abandoned by submitter" or "no >>> movement >>> > from submitter" >>> > - If the submitter responds and keeps the PR alive, please work >>> with >>> > them >>> > - If you are a contributor, please work with the committers to bring >>> > your PRs to a positive outcome >>> > >>> > We currently have <100 open PRs now and are many of you have already >>> > started working on this. >>> > >>> > Bolke, Chris, Dan (aeon), Patrick, Steven : Please update the wiki >>> above at >>> > your earliest convenience. >>> > >>> > Contributors, >>> > If you have thoughts on this process, please share them. >>> > >>> > -s >>> > >>> > On Tue, Oct 11, 2016 at 8:41 AM, siddharth anand <[email protected]> >>> > wrote: >>> > >>> > > Aoen, max? >>> > > >>> > > >>> > > On Monday, October 10, 2016, siddharth anand <[email protected]> >>> wrote: >>> > > >>> > >> Great! Yep, Nov 15th. >>> > >> >>> > >> Thx Arthur and best of luck on your imminent deadline. >>> > >> >>> > >> -s >>> > >> >>> > >> On Mon, Oct 10, 2016 at 10:26 AM, Arthur Wiedmer <[email protected] >>> > >>> > >> wrote: >>> > >> >>> > >>> The deadline is November 15th, not October 15th, right? >>> > >>> >>> > >>> I am finishing a big unrelated project here by the end of the week >>> and >>> > >>> will take some time for Airflow afterwards. Just so Sid is >>> reassured >>> > >>> ;p >>> > >>> >>> > >>> >>> > >>> Best, >>> > >>> Arthur >>> > >>> >>> > >>> On Sat, Oct 8, 2016 at 9:59 AM, siddharth anand <[email protected] >>> > >>> > >>> wrote: >>> > >>> > Excellent.. thanks for committing to that. Are any of the Airbnb >>> > folks >>> > >>> > (Arthur, Dan, Max, Patrick) able to help out? >>> > >>> > >>> > >>> > -s >>> > >>> > >>> > >>> > On Sat, Oct 8, 2016 at 2:25 AM, Sumit Maheshwari < >>> [email protected]> >>> > >>> wrote: >>> > >>> > >>> > >>> >> Hi Sid, >>> > >>> >> >>> > >>> >> I've also picked up my share. >>> > >>> >> >>> > >>> >> >>> > >>> >> Thanks, >>> > >>> >> Sumit >>> > >>> >> >>> > >>> >> On Fri, Oct 7, 2016 at 8:11 AM, siddharth anand < >>> [email protected]> >>> > >>> wrote: >>> > >>> >> >>> > >>> >> > Folks! >>> > >>> >> > >>> > >>> >> > I've changed the title of the wiki to "*Cold Case PR >>> Resolution*" >>> > >>> >> > https://cwiki.apache.org/confluence/display/AIRFLOW/ >>> > >>> >> > Cold-Case+PR+Resolution. >>> > >>> >> > >>> > >>> >> > *Zodiac* and *Jlowin* have signed up for cold-case PRs. I >>> need the >>> > >>> other >>> > >>> >> > committers to also add to the list. >>> > >>> >> > >>> > >>> >> > *As committers on this project, we should aim to resolve all >>> PRs >>> > >>> within 2 >>> > >>> >> > weeks, *if we hope to keep the community happy and the project >>> > >>> healthy! >>> > >>> >> > >>> > >>> >> > Here are some disturbing stats: >>> > >>> >> > >>> > >>> >> > - Currently, of the currently *106 *open PRs, *8* were >>> opened >>> > in >>> > >>> the >>> > >>> >> > past 2 weeks & *20* were opened within the past month >>> > >>> >> > - *90% of our PRs are over 2 weeks old* >>> > >>> >> > - *81% of our PRs are over 1 month old* >>> > >>> >> > >>> > >>> >> > These cold-case PRs will never be looked at again and their >>> > >>> submitters >>> > >>> >> will >>> > >>> >> > likely not submit new fixes. >>> > >>> >> > >>> > >>> >> > I'm noticing a slow down in commits and PRs being opened, >>> which is >>> > >>> likely >>> > >>> >> > due to the fact that we haven't been able to keep up with the >>> PR >>> > >>> volume. >>> > >>> >> > Some people believe that having a lot of open PRs is a sign >>> of a >>> > >>> healthy >>> > >>> >> > project. I'd qualify that statement as having "a lot of >>> recently >>> > >>> opened >>> > >>> >> PRs >>> > >>> >> > is a sign of a healthy project" >>> > >>> >> > >>> > >>> >> > If you are a committer on this project, please pick up 10 >>> CCPRs & >>> > >>> add >>> > >>> >> them >>> > >>> >> > to the list. >>> > >>> >> > -s >>> > >>> >> > >>> > >>> >> > >>> > >>> >> > >>> > >>> >> > >>> > >>> >> > On Tue, Oct 4, 2016 at 1:05 PM, siddharth anand < >>> > [email protected]> >>> > >>> >> wrote: >>> > >>> >> > >>> > >>> >> > > I've added my 10 to https://cwiki.apache.org/co >>> > >>> >> > > nfluence/display/AIRFLOW/Whittling+down+PR+List >>> > >>> >> > > >>> > >>> >> > > Li Xuanji, Sumit, Dan, Arthur, Max, Bolke, Chris, Jeremiah >>> et >>> > al >>> > >>> >> please >>> > >>> >> > > add yours to the list. >>> > >>> >> > > >>> > >>> >> > > On Sun, Oct 2, 2016 at 9:57 AM, siddharth anand < >>> > >>> [email protected]> >>> > >>> >> > wrote: >>> > >>> >> > > >>> > >>> >> > >> Hi Folks, >>> > >>> >> > >> We have in excess of a 100 open PRs. We have 11 committers. >>> > >>> Though >>> > >>> >> > having >>> > >>> >> > >> a lot of open PRs is a sign of a healthy project, the >>> majority >>> > >>> of our >>> > >>> >> > PRs >>> > >>> >> > >> are over 3 months old - that's really not a healthy sign. >>> > >>> >> > >> >>> > >>> >> > >> This is a call to committers to help whittle down this >>> list. >>> > I'd >>> > >>> like >>> > >>> >> > >> each committer to take responsibility for 10 PRs from the >>> > >>> current list >>> > >>> >> > (opened >>> > >>> >> > >> before Oct 2) and help get them to a point of closure by >>> > >>> *November >>> > >>> >> 15*. >>> > >>> >> > >> >>> > >>> >> > >> Some of these might be cold cases.. and will require >>> > >>> contributors to >>> > >>> >> > >> respond in a timely fashion. If you are a contributor and >>> don't >>> > >>> >> respond >>> > >>> >> > to >>> > >>> >> > >> request for PR changes in this timeframe, there is a chance >>> > that >>> > >>> your >>> > >>> >> PR >>> > >>> >> > >> will be closed. >>> > >>> >> > >> >>> > >>> >> > >> To keep us honest, I've created the following list : >>> > >>> >> > >> https://cwiki.apache.org/confluence/display/AIRFLOW/Whittl >>> > >>> >> > >> ing+down+PR+List >>> > >>> >> > >> >>> > >>> >> > >> As you take on PRs from this list, please track them on >>> this >>> > >>> CWiki. >>> > >>> >> > >> >>> > >>> >> > >> -s >>> > >>> >> > >> >>> > >>> >> > > >>> > >>> >> > > >>> > >>> >> > >>> > >>> >> >>> > >>> >>> > >> >>> > >> >>> > > >>> > > -- >>> > > Sent from Gmail Mobile >>> > > >>> > >>> >> >> >
