sekikn opened a new pull request #3676: [AIRFLOW-2829] Brush up the CI script for minikube URL: https://github.com/apache/incubator-airflow/pull/3676 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR" - https://issues.apache.org/jira/browse/AIRFLOW-2829 - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue. ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: Fix scripts/ci/kubernetes/minikube/start_minikube.sh as follows: - Make minikube version configurable via environment variable - Remove unused variables for readability - Reorder some lines to remove warnings - Replace ineffective `return` with `exit` - Add -E to `sudo minikube` so that non-root users can use this script locally ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: No additional test since it's a fix on the setup script for CI. Instead, I ran the revised script locally on Ubuntu 16.04 LTS and confirmed that it worked for both root and non-root user, with the following environmental variables: ``` export KUBERNETES_VERSION=v1.10.0 export MINIKUBE_VERSION=v0.28.2 ``` In addition, I confirmed it worked fine on Travis: https://travis-ci.org/sekikn/incubator-airflow/builds/410712117 ### Commits - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [x] In case of new functionality, my PR adds documentation that describes how to use it. - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added. ### Code Quality - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
