Github user renato2099 commented on the pull request:
https://github.com/apache/any23/pull/18#issuecomment-136161934
This looks great @nisalanirmana !
Just two comments. Adding comments to the classes would actually help a
newcomer like myself understanding better what each class does. I guess that it
is almost self-explanatory with names like "HAdrExtractor" I am guessing it
extracts addresses right? But that is my point, I shouldn't be guessing ;)
And the other thing, I remember seeing somewhere that all code contributed
to ASF was not supposed to have the <author> tag. Maybe @lewismc knows the
truth about it.
Great work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---