[
https://issues.apache.org/jira/browse/ANY23-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333732#comment-16333732
]
ASF GitHub Bot commented on ANY23-324:
--------------------------------------
GitHub user HansBrende opened a pull request:
https://github.com/apache/any23/pull/58
ANY23-324 Changed default html parser from NekoHTML to Jsoup.
This should also indirectly fix ANY23-317, ANY23-273, ANY23-267, and
ANY23-326.
I also added a "any23.tagsoup.legacy" flag in
default-configuration.properties to allow switching back to the NekoHTML
version.
I ran the full suite of tests against this fork using "mvn clean install",
and all tests are passing.
Please let me know if there's anything more I can do to improve this pull
request!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HansBrende/any23 ANY23-324
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit 2c76ada3bc812c37a46863e0529363f42339582a
Author: Hans <firedrake93@...>
Date: 2018-01-18T21:08:27Z
ANY23-324 Changed default html parser from NekoHTML to Jsoup. This also
indirectly fixes ANY23-317, ANY23-273, ANY23-267, and ANY23-326.
----
> Replace net.sourceforge.nekohtml with jsoup
> --------------------------------------------
>
> Key: ANY23-324
> URL: https://issues.apache.org/jira/browse/ANY23-324
> Project: Apache Any23
> Issue Type: Improvement
> Components: core
> Reporter: Lewis John McGibbney
> Priority: Major
> Fix For: 2.2
>
>
> A long standing issue relates to the performance of the existing default
> [TagSoupParser.java|https://github.com/apache/any23/blob/master/core/src/main/java/org/apache/any23/extractor/html/TagSoupParser.java].
> There are a number of issues which now relate to limitations in the way
> nekohtml parses HTML5 for example
> [ANY23-317|https://issues.apache.org/jira/browse/ANY23-317],
> [ANY23-273|https://issues.apache.org/jira/browse/ANY23-273],
> [ANY23-267|https://issues.apache.org/jira/browse/ANY23-267]... there are
> several others.
> I propose to @Deprecate the TagSoupParser.java implementation for the next
> release (possibly making it configurable via
> default-configuration.properties). I also propose to replace it with
> https://jsoup.org/. AFAIK, Apache Tika also did this several years ago.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
