[
https://issues.apache.org/jira/browse/ANY23-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424437#comment-16424437
]
ASF GitHub Bot commented on ANY23-341:
--------------------------------------
Github user HansBrende commented on a diff in the pull request:
https://github.com/apache/any23/pull/71#discussion_r178926732
--- Diff:
core/src/main/java/org/apache/any23/extractor/html/HTMLDocument.java ---
@@ -375,15 +376,16 @@ public String getDefaultLanguage() {
private java.net.URI getBaseIRI() throws ExtractionException {
if (baseIRI == null) {
+ String uri = (document instanceof Document ?
(Document)document : document.getOwnerDocument()).getDocumentURI();
try {
- if (document.getBaseURI() == null) {
- log.warn("document.getBaseURI() is null, this should
not happen");
+ if (uri == null) {
+ log.warn("document.getBaseURI() is null, this should
not happen", new Exception());
--- End diff --
@lewismc Oops, yeah, I added that exception in there just to get the
stacktrace for debugging purposes, but forgot to take it out again!
> Remove dependency on defunct commons-httpclient 3.1
> ---------------------------------------------------
>
> Key: ANY23-341
> URL: https://issues.apache.org/jira/browse/ANY23-341
> Project: Apache Any23
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.2
> Reporter: Hans Brende
> Priority: Minor
> Fix For: 2.3
>
>
> commons-httpclient has been replaced by httpcomponents. It was last updated
> back in 2007. We should remove this dependency.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
