[jira] [Commented] (APEXCORE-488) Issues in SSL communication with StrAM

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/APEXCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378535#comment-15378535
 ] 

ASF GitHub Bot commented on APEXCORE-488:
-----------------------------------------

Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/357#discussion_r70897093
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/util/ConfigUtils.java 
---
    @@ -68,15 +68,30 @@ public static String getRMUsername(Configuration conf)
         return principal;
       }
     
    -  public static String getSchemePrefix(YarnConfiguration conf)
    +  public static boolean isSSLEnabled(Configuration conf)
    +  {
    +    if (HttpConfig.Policy.HTTPS_ONLY == HttpConfig.Policy.fromString(
    +        conf.get(YarnConfiguration.YARN_HTTP_POLICY_KEY, 
YarnConfiguration.YARN_HTTP_POLICY_DEFAULT))) {
    +      return true;
    +    }
    +    return false;
    +  }
    +
    +  public static String getSchemePrefix(Configuration conf)
       {
    -    if (HttpConfig.Policy.HTTPS_ONLY == 
HttpConfig.Policy.fromString(conf.get(YarnConfiguration.YARN_HTTP_POLICY_KEY, 
YarnConfiguration.YARN_HTTP_POLICY_DEFAULT))) {
    +    if (isSSLEnabled(conf)) {
    --- End diff --
    
    Are you good with that explanation @gauravgopi123 


> Issues in SSL communication with StrAM
> --------------------------------------
>
>                 Key: APEXCORE-488
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-488
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: Pradeep A. Dalvi
>            Assignee: Pradeep A. Dalvi
>
> Couple of issues in SSL communication with StrAM to track application progress
>  - trackingURL without protocol scheme, makes YARN to pick up default HTTP. 
> This happens even if the yarn.http.policy is set to HTTPS_ONLY.
>  - StramAgent assumes always HTTP communication



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)