[
https://issues.apache.org/jira/browse/APEXCORE-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483272#comment-15483272
]
ASF GitHub Bot commented on APEXCORE-525:
-----------------------------------------
GitHub user tushargosavi opened a pull request:
https://github.com/apache/apex-core/pull/387
APEXCORE-525 fail validation if statefull streamcodec does not implement
newInstance method.
If user implements a streamcodec extending DefaultStatefulStreamCodec they
need to also remember to implement newInstance method as platform use object
returned by newInstance as codec. If use forget to override newInstance then
platform keep on using default codec without any warning to user and
such error are caught very late mostly resulting incorrect data
distribution and incorrect result at final
operator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tushargosavi/incubator-apex-core APEXCORE-525
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-core/pull/387.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #387
----
commit 8ab11fae86d608d5fb4a3e06153cee056b4cb5d5
Author: Tushar R. Gosavi <[email protected]>
Date: 2016-09-12T06:43:06Z
APEXCORE-525: fail validation if statefull streamcodec does not
implement newInstance method.
----
> DefaultStatefulStreamCodec not implementing newInstance method keep using old
> codec.
> ------------------------------------------------------------------------------------
>
> Key: APEXCORE-525
> URL: https://issues.apache.org/jira/browse/APEXCORE-525
> Project: Apache Apex Core
> Issue Type: Bug
> Reporter: Tushar Gosavi
> Assignee: Tushar Gosavi
>
> Custom stream codec extended from DefaultStatefulStreamCodec but not
> overriding newInstance method keep on using default
> DefaultStatefulStreamCodec without any warning to end user, causing wrong
> result in the application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
