[
https://issues.apache.org/jira/browse/APEXMALHAR-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689342#comment-15689342
]
ASF GitHub Bot commented on APEXMALHAR-2353:
--------------------------------------------
GitHub user bhupeshchawda opened a pull request:
https://github.com/apache/apex-malhar/pull/508
APEXMALHAR-2353 Made timeExpression as @NotNull
@chinmaykolhatkar Please review and merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bhupeshchawda/apex-malhar
APEXMALHAR-2353-dedup-timeExpression
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-malhar/pull/508.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #508
----
commit f617d5e35b08412bcee8fdf0a40e0bc4d317329a
Author: bhupeshchawda <[email protected]>
Date: 2016-11-23T08:25:50Z
APEXMALHAR-2353 Made timeExpression as @NotNull
----
> timeExpression should not be null for time based Dedup
> --------------------------------------------------------
>
> Key: APEXMALHAR-2353
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2353
> Project: Apache Apex Malhar
> Issue Type: Bug
> Reporter: Bhupesh Chawda
> Assignee: Bhupesh Chawda
> Priority: Minor
>
> Time Based Dedup has timeExpression as optional. It has to be supplied by the
> user.
> In the current setting, if the user does not specify a timeExpression, then a
> different time (System time) will be passed for each tuple, irrespective of
> whether the tuple is a duplicate or a unique. This is a bug since even the
> duplicate tuples may fall in different buckets and will be concluded as
> unique.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
