rkundam commented on code in PR #750:
URL: https://github.com/apache/atlas/pull/750#discussion_r4351844871


##########
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java:
##########
@@ -221,10 +223,8 @@ public static boolean isEmbeddedSolr() {
 
     @VisibleForTesting
     static JanusGraph initJanusGraph(Configuration config) {
-        org.apache.commons.configuration2.Configuration conf2 = 
createConfiguration2(config);

Review Comment:
   Could you clarify why we are using config directly to create the JanusGraph 
instance instead of using conf2, which already handles parsing the properties? 
I don't see how this change is related to the OpenSearch integration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to