[
https://issues.apache.org/jira/browse/COCOON-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grzegorz Kossakowski updated COCOON-2038:
-----------------------------------------
Rice, thanks for your explanations!
After reading your comments few times and confronting them with the code I come
to conclusion that your patch is ineed ok.
Another conclusion is that this functionality is non-trivial so bug-endangered
thus I think that it must be covered by automatic tests. Rice, since you seem
to know this code really well, could you make such tests?
I've created recently a little guide helping with writing tests, see:
http://cocoon.zones.apache.org/daisy/cdocs-site-main/g4/g1/636.html
I'm going to commit your patch as soon as some tests cover it. If you can't do
this I'll take a burden myself but I'm not sure when I'll be able to do this.
> Implement true Object Oriented approach for handling super calls
> ----------------------------------------------------------------
>
> Key: COCOON-2038
> URL: https://issues.apache.org/jira/browse/COCOON-2038
> Project: Cocoon
> Issue Type: Task
> Components: - Servlet service framework
> Reporter: Grzegorz Kossakowski
> Assignee: Grzegorz Kossakowski
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: BlockCallHttpServletResponse.java.patch,
> cocoon-servlet-service-impl.patch, DispatcherServlet.java.patch,
> ServletServiceContext.java.patch, StatusRetrievableResponse.java
>
>
> As discussed here: http://thread.gmane.org/gmane.text.xml.cocoon.devel/72317
> implementation of super calls should be changed to make it more OO-like.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
