[ 
https://issues.apache.org/jira/browse/COCOON-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760234#action_12760234
 ] 

Thorsten Scherler commented on COCOON-2269:
-------------------------------------------

Hi Gaurav,

two things:

1) The comment in the java class is the same as in the ImageReader but actually 
the patch is using the ImageMagick API. Meaning the comment can be deleted.

2) can you add a javadoc comment (similar to the description of this issue) 
stating what are the requisitions. 

> JMagick ImageReader based ImageMagick
> -------------------------------------
>
>                 Key: COCOON-2269
>                 URL: https://issues.apache.org/jira/browse/COCOON-2269
>             Project: Cocoon
>          Issue Type: New Feature
>          Components: * Cocoon Core
>    Affects Versions: 2.1.12-dev (Current SVN)
>            Reporter: Gaurav
>             Fix For: 2.1.12-dev (Current SVN)
>
>         Attachments: patch.cocoon.imageMagickReader.txt
>
>
> JMagick is an open source Java interface of ImageMagick. It is implemented in 
> the form of Java Native Interface (JNI) into the ImageMagick API.
> JMagick does not attempt to make the ImageMagick API object-oriented. It is 
> merely a thin interface layer into the ImageMagick API.
> JMagick currently only implements a subset of ImageMagick APIs.
> Till now JMagick has a LGPL (Lesser GNU Public License) license however they 
> are willing to change the license to the apache license.
> ImageMagick is free software delivered as a ready-to-run binary distribution 
> or as source code that you may freely use, copy, modify, and distribute. Its 
> license is compatible with the GPL. It runs on all major operating systems.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to