Github user clelland commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/95#discussion_r10768516
--- Diff: framework/src/org/apache/cordova/Whitelist.java ---
@@ -136,6 +136,14 @@ public void addWhiteListEntry(String origin, boolean
subdomains) {
} else {
whiteList.add(new URLPattern(scheme, host,
port, path));
}
+
+ if( subdomains ){
--- End diff --
This should probably also check `!host.startsWith("*.")`, to avoid
accidentally generating patterns like `*.*.apache.org`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
