Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/154#discussion_r11348541
--- Diff: blackberry10/bin/templates/project/cordova/lib/target-utils.js ---
@@ -254,16 +254,15 @@ _self = {
};
bb10_utils.exec(script, args, options, function (error, stdout,
stderr) {
- // error code 3 corresponds to a connected device, null or
"Error: null" in stderr corresponds to connected emulator
- var isSimConnected = (type === "emulator" && (
+ // error code 3 corresponds to connected device with password
+ // null or "Error: null" in stderr corresponds to connected
simulator or device without password
+ var connected =
error === null ||
+ (error && error.code === 3) ||
--- End diff --
You shouldn't need error &&, because the error === null || should short
circuit it, unless you're expecting someone to pass `error===0` or `error===''`
in which case, i think we have bigger issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
