Jesse wrote:
> again:  I would rather leave the definition of 'trivial' to the reviewer
>of
> the pull request.
>
> An update to docs of 100 lines can be trivial ... Josh renaming 'cordova'
> to 'Cordova' across 3 repos, and 15 files, could be considered trivial
>...
> 4 lines of critical code could be non-trivial.
>
> Note, I am not calling out Josh, I am just making a more specific
>example,
> valuable and trivial are different things.

Nothing wrong with using me as an example of such things. I tend to cover
most interesting edge cases, so it's a good idea to check to see if any of
my actions are relevant edges that should be addressed.

Reply via email to