BUMP!

Would like some more info/discussion before I create a new branch.

On Wed, May 21, 2014 at 12:12 PM, Joe Bowser <[email protected]> wrote:
> On Tue, May 20, 2014 at 11:43 AM, Ian Clelland <[email protected]> wrote:
>> +1
>>
>> I think it's the right time to do this. I'm certainly motivated by
>> pluggable webviews, and if we're going to break things, then lets do them
>> all at once. (And write a good upgrade guide :) )
>>
>> We can create a 4.x branch at the same point as the 3.6.x branch, and merge
>> upstream changes in until it's ready for release as 4.0.0.
>>
>
> Sounds good for the most part.  I'm worried about changes to
> CordovaWebView, CordovaChromeClient and CordovaWebViewClient, since
> every webview needs to implement their own logic.  Perhaps we should
> work on having helper classes for certain things like custom URIs.
>
>> JS is a good question -- we had to make a lot of coordinated changes
>> between the platforms and the common JS code for Cordova 3.0; is there a
>> similar call for JS changes with 4.0? That is, are there cross-platform
>> concerns with a 4.0 release; interfaces that all platforms will need to
>> conform to?
>>
>
> I know that there's a change that Android needs to make to the built
> in app plugin.  This is a big API change, since this changes how the
> back button works, and apparently it's impossible to do this without
> it breaking everything.  I think this has to do with Browserify, but
> I'm not sure.  If someone can comment on this, that'd be great.
>
>> Along those lines, are there other cross-platform features that we want to
>> start working on, that would prompt a 4.0 release of other platforms as
>> well? Or is this where we start getting serious about
>> independently-released platforms?
>>
>
> Good question.  I have no idea.
>
>
>>
>> On Tue, May 20, 2014 at 2:03 PM, Joe Bowser <[email protected]> wrote:
>>
>>> Hey
>>>
>>> So, the more I look at what's happening in Android, the more things
>>> that I see that we have to break, the more I want to create a 4.x
>>> branch.  The reasons for this are obvious:
>>>
>>> - LinearLayout vs RelativeLayout
>>> - Pluggable Weviews
>>> - Changing the App plugin to something else (CoreEvents, similar to
>>> Windows)
>>> - Abstracting custom URIs OUT of WebViewClient/WebChromeClient for
>>> shared logic (see the SMS/hangout bug)
>>> - etc, etc
>>>
>>> Basically, we're going to need to make some changes to Android.  We're
>>> going to pass mobile spec and the JUnit tests, and everything will be
>>> fine, but I think we really need to start putting these fixes in the
>>> 4.x branch and assume that we're going to land this in 4.0.
>>>
>>> I'm thinking that we might want to do this with JS as well for those
>>> changes as well, but I'm not sure.
>>>
>>> Thoughts??
>>>
>>> Joe
>>>

Reply via email to