Exciting! I tried the "check in node_modules" approach in cordova-app-harness and it works really well there: https://github.com/apache/cordova-app-harness/tree/master/harness-push It's a simpler case since there's a strict parent/child relationship.
The main unknown for me is how to make CordovaError work as its own module since we'll require that there is never multiple copies of the module when the end-user types "npm install" (or else the instanceof check won't work). I *think* that npm does the right thing so long as all of the packages use the same version constraints for it, but I haven't tested it. On Fri, Jun 6, 2014 at 11:37 AM, Michal Mocny <[email protected]> wrote: > Brian: sounds good. Looking forward to see where we get. > > -Michal > > > On Fri, Jun 6, 2014 at 11:36 AM, Brian LeRoux <[email protected]> wrote: > > > @Michal: we're going to start extracting things to their own modules. (As > > discussed.) We're going to start small and simple: CordovaError, > > SuperSpawn, etc. But before we do that we'll try to merge up as many PRs > as > > possible. Ideally there are none when we get rolling. (Next week.) > > > > Many repos (or just small modules) would isolate the changes making it > > easier to refactor. Anyhow: I'm tired of advocating that design pattern > > choice and I'm sure you're tired of hearing about it! > > > > > > On Thu, Jun 5, 2014 at 6:04 PM, Michal Mocny <[email protected]> > wrote: > > > > > On Thu, Jun 5, 2014 at 6:47 PM, Brian LeRoux <[email protected]> wrote: > > > > > > > we're about to do some heavy refactoring on cordova-lib…it would > appear > > > > many ppl are working on it atm: > > > > > > > > > > Who/how/what/why? > > > > > > > > > > > > > > https://github.com/apache/cordova-lib/pulls > > > > > > > > I'm afraid to find out how many *aren't* open PR's …but this > certainly > > > > illustrates the problem with one giant repo with all our code > > > > > > > > > > If you are refactoring the code in a way that breaks PR from applying, > I > > > don't think multiple repos would make a difference. Probably this way > is > > > easier if you were making changes that needed to touch multiple repos. > > But > > > this conversation feels sorta Deja Vu. > > > > > > -Michal > > > > > >
