I agree with this balance that Tommy proposed. Having a simple one liner by default it shows intention, and progress (i.e. not halted).
--Carlos On Fri, Jun 13, 2014 at 9:15 PM, tommy-carlos williams <[email protected]> wrote: > My personal preference would be (but this is overall, not just for hooks): > > cordova (no flags): gives minimal stage info – preparing blah, compiling > foo, running after_prepare hook, etc. I would only have the “running > after_prepare hook” if there actually *is* an after_prepare hook to run. > > cordova (—verbose or -d): full output of all scripts as well as stage info > above. > > cordova (—silent or -s): completely silent unless there is an error. This > would be best for CI or build slave environments where you only want to be > notified if something goes wrong > > > > > > > > > On 14 June 2014 at 7:06:05, Michal Mocny ([email protected]) wrote: > > Landed the change to make this verbose only since the current behaviour is > certainly not a great default. We can add subsequent improvements to how > we report on hooks firing as need arises (though honestly no one complained > about this so far, perhaps hooks are not all that commonly used). > > > On Fri, Jun 13, 2014 at 5:00 PM, Michal Mocny <[email protected]> wrote: > > > "running X hooks" is not trivial to implement given how it works today. > > You would have to pre-calculate how many scripts will run in response to > > any action, and some actions are compound. I.e. "cordova run" you have to > > count before/after from all of {prepare, build, run} (and more?), and we > > just don't do that sort of accounting right now. > > > > Its not that difficult to add and we should file a feature request to > > better manage how hooks run, but I'm pretty sure there are better uses of > > effort short-term. > > > > -Michal > > > > > > On Fri, Jun 13, 2014 at 4:08 PM, Lorin Beer <[email protected]> > wrote: > > > >> as someone who uses hooks, I think that's a good idea > >> > >> 1. non verbose mode should simply output something like "running X > hooks" > >> 2. verbose mode can output more details of the scripts being run > >> > >> On Fri, Jun 13, 2014 at 1:05 PM, Michal Mocny <[email protected]> > wrote: > >> > https://issues.apache.org/jira/browse/CB-6942 > >> > > >> > > >> > On Fri, Jun 13, 2014 at 3:51 PM, Michal Mocny <[email protected]> > >> wrote: > >> > > >> >> Hey all, > >> >> > >> >> I'd like to change cordova-cli to not always print multiple messages > >> like > >> >> "Running command: ..." when it runs hooks. I'd like this to happen > >> only if > >> >> you have verbose logging on (with -d or --verbose). > >> >> > >> >> I think this was a regression added in February, but since its been > in > >> a > >> >> few releases with no complaints (likely because most projects don't > use > >> >> hooks), I wonder if others feel this is a useful default (I don't > >> think it > >> >> is)? > >> >> > >> >> Tommy: you guys use hooks in your projects a lot, what do you think? > >> >> > >> >> If it is a useful default, I'll instead add a way to opt-out without > >> >> disabling absolutely all logging with --silent. > >> >> > >> >> -Michal > >> >> > >> > > > > > > -- Carlos Santana <[email protected]>
