Canceling this vote. This version would fail on windows without the latest windows platform version which is expected to be released with 3.6.
On Thu, Jun 26, 2014 at 2:43 PM, Sergey Grebnov (Akvelon) < [email protected]> wrote: > Example is 'cordova platform add windows8' will fail since updated code > expects check_reqs in different folder ('\windows\bin\', instead of > '\windows8\bin\' as it is in old template). There are another issues. > > In this situation I propose to revert the entire original commit. Thoughts? > CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1) > > https://github.com/apache/cordova-lib/commit/7ed25a53a793a2af3ff3bc51799ef65fa302a643 > > Thx! > Sergey > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of Andrew > Grieve > Sent: Thursday, June 26, 2014 6:17 PM > To: dev > Subject: Re: [Vote] Tools Release > > Sergey - could you clarify what the bug here is? E.g. Is there a > regression? Does this make "cordova run" not work? > > If it really does need to be applied - checking in commented-out code is > not the way to go about. You should add "if (version >= 3.6.0)" checks > around things like is done here: > > > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=blob;f=cordova-lib/src/cordova/platform.js;h=be10f92aee6e5b4c7863c2ff66448d07266e4091;hb=master#l426 > > > > > On Thu, Jun 26, 2014 at 9:57 AM, Sergey Grebnov (Akvelon) < > [email protected]> wrote: > > > For the Windows Universal Apps feature we need to co-release Tools and > > Windows platform to get it working. Since this is a 3.5.0-minor > > release people who already downloaded windows platform won't receive > > updated template and this will break functionality. > > > > I've sent the following PRs to disable related functionality to get > > cordova working. Can we apply those changes? > > https://github.com/apache/cordova-lib/pull/41 > > https://github.com/apache/cordova-cli/pull/182 > > > > I will then enable it back so that we release this along with 3.6.0. > > > > Thx! > > Sergey > > -----Original Message----- > > From: Carlos Santana [mailto:[email protected]] > > Sent: Wednesday, June 25, 2014 6:49 PM > > To: [email protected] > > Subject: Re: [Vote] Tools Release > > > > If its not a regression and critical issue let's not stop a vote to > > release, we can always pick bugs in the next release as soon as we want. > > > > But we should try to keep the releases going out, the voting is to > > make sure what we release is correct and no critical regressions. > > > > > > > > On Wed, Jun 25, 2014 at 10:46 AM, Ian Clelland > > <[email protected]> > > wrote: > > > > > There are similar issues for Android when a package name starts with > > > a number or underscore, I think. > > > > > > As long as it's not a regression, I'd rather not cancel the vote for > > > it; we're always going to find more bugs (if we look hard enough :) > > > ) We can release again with both fixes as soon as we want. > > > > > > Ian > > > > > > > > > On Wed, Jun 25, 2014 at 10:39 AM, Sergey Grebnov (Akvelon) < > > > [email protected]> wrote: > > > > > > > Hi, I've recently found out the following bad issue when iOS > > > > platform add/prepare fails if app display name contains unicode > > > > characters. We may want to include it to release. > > > > https://issues.apache.org/jira/browse/CB-6992 > > > > https://github.com/apache/cordova-lib/pull/40 > > > > > > > > Thx! > > > > Sergey > > > > -----Original Message----- > > > > From: [email protected] [mailto:[email protected]] On Behalf > > > > Of > > > Ian > > > > Clelland > > > > Sent: Wednesday, June 25, 2014 6:37 AM > > > > To: [email protected] > > > > Subject: Re: [Vote] Tools Release > > > > > > > > +1 > > > > > > > > Verified package integrity (and signed Mark's GPG key after > > > > validating > > > it) > > > > Verified that packages match the repositories at the correct tags > > > > Tested building mobile spec with the tagged repos Ran npm test in > > > > all three packages to see that there are no failing tests > > > > > > > > > > > > > > > > On Tue, Jun 24, 2014 at 10:27 PM, Mark Koudritsky > > > > <[email protected]> > > > > wrote: > > > > > > > > > Ok, updated the packages, git tags are the same. Please test and > > vote. > > > > > Signed packages: > > > > > https://dist.apache.org/repos/dist/dev/cordova/CB-7002/ > > > > > > > > > > > > > > > PS: > > > > > The problems with old packages were > > > > > - plugman and cli were taken with the next -dev version in > > > package.json. > > > > > - cordova-lib was zipped rather than "npm pack"-ed because > > > > > package.json lives in a subdir and not in repo root. > > > > > > > > > > > > > > > > > > > > -- > > Carlos Santana > > <[email protected]> > > >
