Looks like it went missing in efcedab (according to git log -S) Agreed that it's frustrating. (And I liked getPlugin, too). I'd like for the 4.0.x branch to remain pretty fast-moving; I don't want to have to have long discussions on the list before every commit, but breaking the public API isn't good. It breaks everyone's workflow, since we all have code that lives outside of the core that relies on it.
On Tue, Jul 15, 2014 at 1:56 PM, Joe Bowser <[email protected]> wrote: > I was talking about getPlugin(), not getPluginManager(). We used to > have that method, and it's gone, and I'm asking here hoping that I > don't have to sift through the 30 commits that were put in the repo to > figure out where it went. If there was a good tool to check all 30+ > commits that happened, that'd help too, but this is extremely > frustrating, since I want to demo something. > > On Tue, Jul 15, 2014 at 10:48 AM, Andrew Grieve <[email protected]> > wrote: > > I don't think it's been removed: > > > https://github.com/apache/cordova-android/blob/4.0.x/framework/src/org/apache/cordova/CordovaWebView.java#L81 > > > https://github.com/apache/cordova-android/blob/4.0.x/framework/src/org/apache/cordova/AndroidWebView.java#L732 > > > > > > On Tue, Jul 15, 2014 at 1:33 PM, Joe Bowser <[email protected]> wrote: > > > >> Hey > >> > >> One of the new API methods that we added to the WebView was removed. > >> I'm not sure why it was, since we now have to get a PluginManager to > >> get a plugin. Aren't we closing off access to the PluginManager? > >> Seriously, this should have been discussed before we commit things. > >> > >> Joe > >> >
